[hotfix] use legacy case-when format before releasing 0.13 #10291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterddr
changed the title
Codecov Report
@@ Coverage Diff @@
## master #10291 +/- ##
=============================================
+ Coverage 13.71% 70.42% +56.70%
- Complexity 182 5117 +4935
=============================================
Files 1961 2016 +55
Lines 106866 109636 +2770
Branches 16326 16681 +355
=============================================
+ Hits 14661 77214 +62553
+ Misses 91046 26996 -64050
- Partials 1159 5426 +4267
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mayankshriv
approved these changes
Feb 16, 2023
Contributor
mayankshriv
left a comment
mayankshriv
left a comment
There was a problem hiding this comment.
@walterddr are we reverting the change, what's the plan on zero downtime upgrade for next 0.13? Or will that not have an issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up on #9702. I misunderstood the upgrade order to be server-->broker->controller; with this change we are good for controller->broker->server