Index spi: remove columnindextype #10194
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gortiz
changed the title
This was referenced Jan 27, 2023
…pinot into index-spi-remove-columnindextype
…es' into index-spi-all-types
…o index-spi-index-service
Codecov Report
@@ Coverage Diff @@
## master #10194 +/- ##
=============================================
- Coverage 70.26% 24.32% -45.94%
+ Complexity 6130 58 -6072
=============================================
Files 2056 2054 -2
Lines 111534 110930 -604
Branches 16962 16884 -78
=============================================
- Hits 78372 26988 -51384
- Misses 27647 81160 +53513
+ Partials 5515 2782 -2733
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1492 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial draft PR related to #10183. The whole PR is in #10184. It isn't intended to be merged as it is and it doesn't require to compile or pass the checks. It has been created in order to make it easier to understand the PR with all the changes.
This PR depends on #10193. Readers only interested in the difference between this and the previous PR can focus on gortiz#3
In this PR,
ColumnIndexTypehas been deleted and its usages replaces by using eitherStandardIndexesorIndexService. Like previous PRs, this almost doesn't contain important code changes. The most significant change is on how the file extension used by V1 and V2 segments is calculated. It was previously implemented with aswitch. Obviously we cannot use a switch with classes in Java, so usually we would need to change it with a bunch of if-then-else (like this PR does with IndexHandlerFactory) but if that was the case, given that the number of indexes is not defined at compile time we need another solution and the easiest way to do that is to move the responsibility of how to calculate the extension into the IndexType itself.