[multistage][poc][do-not-review] flag all columns as nullable #10148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10148 +/- ##
=============================================
+ Coverage 24.75% 34.92% +10.17%
- Complexity 44 200 +156
=============================================
Files 1988 2005 +17
Lines 108125 108548 +423
Branches 16446 16488 +42
=============================================
+ Hits 26763 37909 +11146
+ Misses 78560 67369 -11191
- Partials 2802 3270 +468
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| switch (fieldSpec.getDataType()) { | ||
| case INT: | ||
| return createSqlType(SqlTypeName.INTEGER); | ||
| return createTypeWithNullability(createSqlType(SqlTypeName.INTEGER), true); |
Contributor
There was a problem hiding this comment.
Can you check this patch with the COLOCATED_JOIN quickstart and this query? I saw a broadcast distributed stage created for some reason. Also the projection wasn't pushed down to the userAttributes side.
SELECT
COUNT(*)
FROM
userAttributes_OFFLINE
WHERE
userUUID NOT IN (
SELECT userUUID FROM userGroups_OFFLINE WHERE groupUUID = 'group-2'
)
Contributor
Author
|
this have introduce new set of issues. so we really need a proper null detection on columns. will shelf this PR for now |
walterddr
changed the title
Contributor
Author
|
closing until proper null support is in place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, there's no way to tell whether a table column is nullable
setting the nullability for all columns on v2 engine as default true (previously default false), b/c