Skip to content

support EXPR_MIN/EXPR_MAX #11254

@walterddr

Description

@walterddr

currently the ARG_MIN/ARG_MAX syntax added in #10636 isn't actually the latest supported operand type checker format in Calcite.

Namely, ARG_MIN/ARG_MAX(comp[, comp]*, value) puts the mandatory value column at the end and the optional comparison in the middle. and incompatible with Calcite's syntax ARG_MIN/ARG_MAX(value, comp)

we propose to

  1. use a new syntax EXPR_MIN(value, comp[, comp]*) which is inline with ARG_MIN/ARG_MAX(value, comp) when no optional secondary comp columns are attached
  2. migrate ARG_MIN/ARG_MAX to the new syntax and
  3. [optional] if Calcite adopts the optional comp column we can further use ARG_MIN/ARG_MAX as synonym of EXPR_MIN/EXPR_MAX in the future.

CC @jasperjiaguo @Jackie-Jiang @xiangfu0

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions