earliest|latest -> smallest|largest

sajjad-moradi · sajjad-moradi · commit c43ae7054a2c · 2022-08-29T12:49:40.000-07:00
diff --git a/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java b/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java
@@ -84,22 +84,15 @@ public Response pauseConsumption(
           + "gone, the first available offsets are picked to minimize the data loss.")
   public Response resumeConsumption(
       @ApiParam(value = "Name of the table", required = true) @PathParam("tableName") String tableName,
-      @ApiParam(value = "earliest | latest | best") @QueryParam("consumeFrom") String consumeFrom) {
+      @ApiParam(value = "smallest | largest") @QueryParam("consumeFrom") String consumeFrom) {
     String tableNameWithType = TableNameBuilder.REALTIME.tableNameWithType(tableName);
     validate(tableNameWithType);
-    String offsetCriteria;
-    if ("earliest".equalsIgnoreCase(consumeFrom)) {
-      offsetCriteria = "smallest";
-    } else if ("latest".equalsIgnoreCase(consumeFrom)) {
-      offsetCriteria = "largest";
-    } else if (consumeFrom == null || "best".equalsIgnoreCase(consumeFrom)) {
-      offsetCriteria = null;
-    } else {
+    if (consumeFrom != null && !consumeFrom.equalsIgnoreCase("smallest") && !consumeFrom.equalsIgnoreCase("largest")) {
       throw new ControllerApplicationException(LOGGER,
           String.format("consumeFrom param '%s' is not valid.", consumeFrom), Response.Status.BAD_REQUEST);
     }
     try {
-      return Response.ok(_pinotLLCRealtimeSegmentManager.resumeConsumption(tableNameWithType, offsetCriteria)).build();
+      return Response.ok(_pinotLLCRealtimeSegmentManager.resumeConsumption(tableNameWithType, consumeFrom)).build();
     } catch (Exception e) {
       throw new ControllerApplicationException(LOGGER, e.getMessage(), Response.Status.INTERNAL_SERVER_ERROR, e);
     }
