Skip to content

Commit b239724

Browse files
committed
Address comments
1 parent 3c3da4c commit b239724

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1483,6 +1483,7 @@ static void setOptions(PinotQuery pinotQuery, long requestId, String query, Json
14831483
if (jsonRequest.has(Broker.Request.DEBUG_OPTIONS)) {
14841484
Map<String, String> debugOptions = getOptionsFromJson(jsonRequest, Broker.Request.DEBUG_OPTIONS);
14851485
if (!debugOptions.isEmpty()) {
1486+
// TODO: Do not set debug options after releasing 0.11.0. Currently we kept it for backward compatibility.
14861487
LOGGER.debug("Debug options are set to: {} for request {}: {}", debugOptions, requestId, query);
14871488
pinotQuery.setDebugOptions(debugOptions);
14881489

pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentselector/RealtimeSegmentSelector.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ public void onAssignmentChange(IdealState idealState, ExternalView externalView,
9393
if (instanceStateMap.containsValue(SegmentStateModel.CONSUMING)) {
9494
// Keep the first CONSUMING segment for each partition
9595
LLCSegmentName llcSegmentName = new LLCSegmentName(segment);
96-
partitionIdToFirstConsumingLLCSegmentMap.compute(llcSegmentName.getPartitionGroupId(),
97-
(k, consumingSegment) -> {
96+
partitionIdToFirstConsumingLLCSegmentMap
97+
.compute(llcSegmentName.getPartitionGroupId(), (k, consumingSegment) -> {
9898
if (consumingSegment == null) {
9999
return llcSegmentName;
100100
} else {

pinot-core/src/main/java/org/apache/pinot/core/startree/operator/StarTreeFilterOperator.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -197,14 +197,14 @@ private BaseFilterOperator getFilterOperator() {
197197
int numPredicateEvaluators = predicateEvaluators.size();
198198
if (numPredicateEvaluators == 1) {
199199
// Single predicate evaluator
200-
childFilterOperators.add(
201-
FilterOperatorUtils.getLeafFilterOperator(predicateEvaluators.get(0), dataSource, numDocs));
200+
childFilterOperators
201+
.add(FilterOperatorUtils.getLeafFilterOperator(predicateEvaluators.get(0), dataSource, numDocs));
202202
} else {
203203
// Predicate evaluators conjoined with OR
204204
List<BaseFilterOperator> orChildFilterOperators = new ArrayList<>(numPredicateEvaluators);
205205
for (PredicateEvaluator childPredicateEvaluator : predicateEvaluators) {
206-
orChildFilterOperators.add(
207-
FilterOperatorUtils.getLeafFilterOperator(childPredicateEvaluator, dataSource, numDocs));
206+
orChildFilterOperators
207+
.add(FilterOperatorUtils.getLeafFilterOperator(childPredicateEvaluator, dataSource, numDocs));
208208
}
209209
childFilterOperators.add(
210210
FilterOperatorUtils.getOrFilterOperator(_queryContext, orChildFilterOperators, numDocs));

0 commit comments

Comments
 (0)