Fix metadata push mode in IngestionUtils (#8802)

lksvenoy-r7 · web-flow · commit 9abf15fd6dee · 2022-06-01T03:21:06.000-07:00
* Fix bug in IngestionUtils creating segment uri to tar map

* Use new String[0] instead of static method reference
diff --git a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/IngestionUtils.java b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/IngestionUtils.java
@@ -240,7 +240,7 @@ public static void uploadSegment(String tableNameWithType, BatchConfig batchConf
           }
           PinotFS outputFileFS = getOutputPinotFS(batchConfig, outputSegmentDirURI);
           Map<String, String> segmentUriToTarPathMap = SegmentPushUtils.getSegmentUriToTarPathMap(outputSegmentDirURI,
-              segmentUploadSpec.getPushJobSpec(), new String[] { segmentTarURIs.toString() });
+              segmentUploadSpec.getPushJobSpec(), segmentTarURIStrs.toArray(new String[0]));
           SegmentPushUtils.sendSegmentUriAndMetadata(segmentUploadSpec, outputFileFS, segmentUriToTarPathMap);
         } catch (RetriableOperationException | AttemptsExceededException e) {
           throw new RuntimeException(String

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ public static void uploadSegment(String tableNameWithType, BatchConfig batchConf`
`240`	`240`	`}`
`241`	`241`	`PinotFS outputFileFS = getOutputPinotFS(batchConfig, outputSegmentDirURI);`
`242`	`242`	`Map<String, String> segmentUriToTarPathMap = SegmentPushUtils.getSegmentUriToTarPathMap(outputSegmentDirURI,`
`243`		`- segmentUploadSpec.getPushJobSpec(), new String[] { segmentTarURIs.toString() });`
	`243`	`+ segmentUploadSpec.getPushJobSpec(), segmentTarURIStrs.toArray(new String[0]));`
`244`	`244`	`SegmentPushUtils.sendSegmentUriAndMetadata(segmentUploadSpec, outputFileFS, segmentUriToTarPathMap);`
`245`	`245`	`} catch (RetriableOperationException \| AttemptsExceededException e) {`
`246`	`246`	`throw new RuntimeException(String`