Add docId and column name to segment read exception (#9512)

KKcorps · web-flow · commit 421154f1d945 · 2022-10-02T20:56:59.000-07:00
diff --git a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java
@@ -229,7 +229,8 @@ public GenericRow getRecord(int docId, GenericRow reuse) {
       _pinotSegmentRecordReader.getRecord(reuse, docId);
       return reuse;
     } catch (Exception e) {
-      throw new RuntimeException("Failed to use PinotSegmentRecordReader to read immutable segment");
+      throw new RuntimeException(
+          String.format("Failed to use PinotSegmentRecordReader to read immutable segment for docId: %d", docId), e);
     }
   }
 
@@ -242,7 +243,9 @@ public Object getValue(int docId, String column) {
       }
       return _pinotSegmentRecordReader.getValue(docId, column);
     } catch (Exception e) {
-      throw new RuntimeException("Failed to use PinotSegmentRecordReader to read value from immutable segment");
+      throw new RuntimeException(
+          String.format("Failed to use PinotSegmentRecordReader to read value from immutable segment"
+              + " for docId: %d, column: %s", docId, column), e);
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,8 @@ public GenericRow getRecord(int docId, GenericRow reuse) {`
`229`	`229`	`_pinotSegmentRecordReader.getRecord(reuse, docId);`
`230`	`230`	`return reuse;`
`231`	`231`	`} catch (Exception e) {`
`232`		`- throw new RuntimeException("Failed to use PinotSegmentRecordReader to read immutable segment");`
	`232`	`+ throw new RuntimeException(`
	`233`	`+ String.format("Failed to use PinotSegmentRecordReader to read immutable segment for docId: %d", docId), e);`
`233`	`234`	`}`
`234`	`235`	`}`
`235`	`236`
`@@ -242,7 +243,9 @@ public Object getValue(int docId, String column) {`
`242`	`243`	`}`
`243`	`244`	`return _pinotSegmentRecordReader.getValue(docId, column);`
`244`	`245`	`} catch (Exception e) {`
`245`		`- throw new RuntimeException("Failed to use PinotSegmentRecordReader to read value from immutable segment");`
	`246`	`+ throw new RuntimeException(`
	`247`	`+ String.format("Failed to use PinotSegmentRecordReader to read value from immutable segment"`
	`248`	`+ + " for docId: %d, column: %s", docId, column), e);`
`246`	`249`	`}`
`247`	`250`	`}`
`248`	`251`	`}`