Fix null pointer exception in segment debug endpoint (#11228)

cbalci · web-flow · commit 030d9c08c836 · 2023-07-31T09:26:05.000-07:00
diff --git a/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/DebugResource.java b/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/DebugResource.java
@@ -349,7 +349,7 @@ private List<TableDebugInfo.SegmentDebugInfo> debugSegments(PinotHelixResourceMa
           Map<String, SegmentServerDebugInfo> segmentServerDebugInfoMap = segmentEntry.getValue();
           SegmentServerDebugInfo segmentServerDebugInfo = segmentServerDebugInfoMap.get(segmentName);
 
-          if (verbosity > 0 || (segmentServerDebugInfo != null) && segmentHasErrors(segmentServerDebugInfo, evState)) {
+          if (segmentServerDebugInfo != null && (verbosity > 0 || segmentHasErrors(segmentServerDebugInfo, evState))) {
             segmentServerState.put(instanceName,
                 new TableDebugInfo.SegmentState(isState, evState, segmentServerDebugInfo.getSegmentSize(),
                     segmentServerDebugInfo.getConsumerInfo(), segmentServerDebugInfo.getErrorInfo()));
