chore: Make timeoutCompletionStage accept java Duration.#2063
Merged
Conversation
He-Pin
force-pushed
the
timeoutCompletionStage
branch
2 times, most recently
from
fc2b594 to
6733daa
Compare
He-Pin
force-pushed
the
timeoutCompletionStage
branch
from
6733daa to
76e1550
Compare
pjfanning
reviewed
Aug 23, 2025
pjfanning
reviewed
Aug 23, 2025
actor/src/main/scala/org/apache/pekko/pattern/FutureTimeoutSupport.scala
Outdated
Show resolved
Hide resolved
He-Pin
force-pushed
the
timeoutCompletionStage
branch
from
76e1550 to
9c7f5e5
Compare
He-Pin
added a commit
to He-Pin/incubator-pekko
that referenced
this pull request
Aug 23, 2025
(cherry picked from commit 442ecd7)
He-Pin
added a commit
that referenced
this pull request
Aug 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
This method should accept Java's duration
Should be backported to 1.2.0 too