add test file for page index filter.#25
Merged
wesm merged 2 commits intoapache:masterfrom Jul 4, 2022
Merged
Conversation
Member
Author
alamb
approved these changes
Jul 2, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @Ted-Jiang
data/README.md
Outdated
| |null_list.parquet | an empty list. Generated from this json `{"emptylist":[]}` and for the purposes of testing correct read/write behaviour of this base case. | | ||
| | null_list.parquet | an empty list. Generated from this json `{"emptylist":[]}` and for the purposes of testing correct read/write behaviour of this base case. | | ||
| | alltypes_tiny_pages.parquet | small page sizes with dictionary encoding with page index | | ||
| | alltypes_tiny_pages_plain.parquet | small page sizes without dictionary encoding with page index | |
Contributor
There was a problem hiding this comment.
Maybe we can also mention the file's lineage (that it came from impala, with link) in this comment
data/README.md
Outdated
| |null_list.parquet | an empty list. Generated from this json `{"emptylist":[]}` and for the purposes of testing correct read/write behaviour of this base case. | | ||
| | null_list.parquet | an empty list. Generated from this json `{"emptylist":[]}` and for the purposes of testing correct read/write behaviour of this base case. | | ||
| | alltypes_tiny_pages.parquet | small page sizes with dictionary encoding with page index | | ||
| | alltypes_tiny_pages_plain.parquet | small page sizes without dictionary encoding with page index | |
Contributor
There was a problem hiding this comment.
Suggested change
| | alltypes_tiny_pages_plain.parquet | small page sizes without dictionary encoding with page index | | |
| | alltypes_tiny_pages_plain.parquet | small page sizes with plain encoding with page index | |
Member
Author
|
@wesm could please take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related apache/arrow-rs#1977 (comment)
Add test file for page index, copy from impala https://github.com/apache/impala/blob/bb610dee09a8069bb993b4c668f7e481c1774b70/testdata/data/alltypes_tiny_pages.parquet