PARQUET-142: add path filter in ParquetReader#89
Closed
nevillelyh wants to merge 1 commit intoapache:masterfrom
Closed
PARQUET-142: add path filter in ParquetReader#89nevillelyh wants to merge 1 commit intoapache:masterfrom
nevillelyh wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Thanks @nevillelyh! The patch looks good, but could you prefix this PR title and the commit message with the JIRA issue id? We use that as a way to keep track and make sure all commits are for an issue, so we can't merge this until that's fixed. Thanks! |
nevillelyh
force-pushed
the
gh/path-filter
branch
from
3f50953 to
7377a20
Compare
nevillelyh
changed the title
Contributor
Author
|
@rdblue fixed, thanks. |
Contributor
|
@tomwhite and @julienledem, what do you think about merging this? This is a behavior change, but I don't think we have behavior guarantees for parquet-tools. I also see this as more of a bugfix because it is far more common that users have a _SUCCESS file than it is for users to expect the tool to pick up dot files. I'm +1. |
Member
|
+1 this sounds good to me. |
Contributor
|
I've merged this. Thanks @nevillelyh! |
dongche
pushed a commit
to dongche/incubator-parquet-mr
that referenced
this pull request
Feb 3, 2015
Currently parquet-tools command fails when input is a directory with _SUCCESS file from mapreduce. Filtering those out like ParquetFileReader does fixes the problem. ``` parquet-cat /tmp/parquet_write_test Could not read footer: java.lang.RuntimeException: file:/tmp/parquet_write_test/_SUCCESS is not a Parquet file (too small) $ tree /tmp/parquet_write_test /tmp/parquet_write_test ├── part-m-00000.parquet └── _SUCCESS ``` Author: Neville Li <[email protected]> Closes apache#89 from nevillelyh/gh/path-filter and squashes the following commits: 7377a20 [Neville Li] PARQUET-142: add path filter in ParquetReader
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Mar 9, 2015
Currently parquet-tools command fails when input is a directory with _SUCCESS file from mapreduce. Filtering those out like ParquetFileReader does fixes the problem. ``` parquet-cat /tmp/parquet_write_test Could not read footer: java.lang.RuntimeException: file:/tmp/parquet_write_test/_SUCCESS is not a Parquet file (too small) $ tree /tmp/parquet_write_test /tmp/parquet_write_test ├── part-m-00000.parquet └── _SUCCESS ``` Author: Neville Li <[email protected]> Closes apache#89 from nevillelyh/gh/path-filter and squashes the following commits: 7377a20 [Neville Li] PARQUET-142: add path filter in ParquetReader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently parquet-tools command fails when input is a directory with _SUCCESS file from mapreduce. Filtering those out like ParquetFileReader does fixes the problem.