PARQUET-141: upgrade to scrooge 3.17.0, remove reflection based field info inspection...#88
Closed
tsdeng wants to merge 5 commits intoapache:masterfrom
Closed
PARQUET-141: upgrade to scrooge 3.17.0, remove reflection based field info inspection...#88tsdeng wants to merge 5 commits intoapache:masterfrom
tsdeng wants to merge 5 commits intoapache:masterfrom
Conversation
…ion, support enum and requirement type correctly
tsdeng
changed the title
tsdeng
changed the title
Member
There was a problem hiding this comment.
Class instead of ClassName ?
Member
|
some minor stylistic comments. Otherwise this look good to me. |
Contributor
Author
|
@julienledem the test passes locally, and the log from CI seems to be incomplete, how should we trigger rebuilding this branch? |
Member
|
+1 |
1 similar comment
Contributor
|
+1 |
dongche
pushed a commit
to dongche/incubator-parquet-mr
that referenced
this pull request
Feb 3, 2015
… info inspection... upgrade to scrooge 3.17.0, remove reflection based field info inspection, support enum and requirement type correctly This PR is essential for scrooge write support https://github.com/apache/incubator-parquet-mr/pull/58 Author: Tianshuo Deng <[email protected]> Closes apache#88 from tsdeng/scrooge_schema_converter_upgrade and squashes the following commits: 77cc12a [Tianshuo Deng] delete empty line, retrigger jenkins 80d61ad [Tianshuo Deng] format 26e1fe1 [Tianshuo Deng] fix exception handling 706497d [Tianshuo Deng] support union 1b51f0f [Tianshuo Deng] upgrade to scrooge 3.17.0, remove reflection based field info inspection, support enum and requirement type correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upgrade to scrooge 3.17.0, remove reflection based field info inspection, support enum and requirement type correctly
This PR is essential for scrooge write support https://github.com/apache/incubator-parquet-mr/pull/58