PARQUET-124: normalize path checking to prevent mismatch between URI and ...#79
Closed
chrisalbright wants to merge 3 commits intoapache:masterfrom
Closed
PARQUET-124: normalize path checking to prevent mismatch between URI and ...#79chrisalbright wants to merge 3 commits intoapache:masterfrom
chrisalbright wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
|
Hi @chrisalbright, I just tried to merge this and the script failed because the title doesn't have a ":" after the JIRA number. Could you update it? |
Contributor
Author
|
how embarrasing :/ I have been checking on the JIRA ticket but not here. I'll update the commit message, and re-push, but will that be a problem for you trying to merge? |
Contributor
|
No, it should be fine. Would you mind rebasing on master? That would make it much easier to pull. |
Contributor
Author
|
Ok @rdblue commit message re-written - sorry for the d-e-l-a-a-a-y |
chrisalbright
changed the title
Conflicts: parquet-hadoop/src/test/java/parquet/hadoop/TestParquetFileWriter.java
Member
|
@rdblue did you want to merge? |
Contributor
|
Merged! Thanks @chrisalbright! |
dongche
pushed a commit
to dongche/incubator-parquet-mr
that referenced
this pull request
Feb 3, 2015
…and ... ...path Author: Chris Albright <[email protected]> Closes apache#79 from chrisalbright/master and squashes the following commits: b1b0086 [Chris Albright] Merge remote-tracking branch 'upstream/master' 9669427 [Chris Albright] PARQUET-124: Adding test (Thanks Ryan Blue) that proves mergeFooters was failing 8e342ed [Chris Albright] PARQUET-124: normalize path checking to prevent mismatch between URI and path
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Mar 9, 2015
…and ... ...path Author: Chris Albright <[email protected]> Closes apache#79 from chrisalbright/master and squashes the following commits: b1b0086 [Chris Albright] Merge remote-tracking branch 'upstream/master' 9669427 [Chris Albright] PARQUET-124: Adding test (Thanks Ryan Blue) that proves mergeFooters was failing 8e342ed [Chris Albright] PARQUET-124: normalize path checking to prevent mismatch between URI and path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...path