PARQUET-181: Scrooge Write Support (take two)#58
Closed
colinmarc wants to merge 2 commits intoapache:masterfrom
Closed
PARQUET-181: Scrooge Write Support (take two)#58colinmarc wants to merge 2 commits intoapache:masterfrom
colinmarc wants to merge 2 commits intoapache:masterfrom
Conversation
colinmarc
force-pushed
the
scrooge-write-support-2
branch
2 times, most recently
from
408a30e to
13eef4d
Compare
asfgit
referenced
this pull request
Jan 13, 2015
… info inspection... upgrade to scrooge 3.17.0, remove reflection based field info inspection, support enum and requirement type correctly This PR is essential for scrooge write support https://github.com/apache/incubator-parquet-mr/pull/58 Author: Tianshuo Deng <[email protected]> Closes #88 from tsdeng/scrooge_schema_converter_upgrade and squashes the following commits: 77cc12a [Tianshuo Deng] delete empty line, retrigger jenkins 80d61ad [Tianshuo Deng] format 26e1fe1 [Tianshuo Deng] fix exception handling 706497d [Tianshuo Deng] support union 1b51f0f [Tianshuo Deng] upgrade to scrooge 3.17.0, remove reflection based field info inspection, support enum and requirement type correctly
Contributor
|
I just closed apache/incubator-parquet-mr@52f3240 @colinmarc could you rebase your change to master? |
Also: - create an AbstractThriftWriteSupport, and pull functionality into it - add TBaseWriteSupport, to replace ThriftWriteSupport - Deprecate ThriftWriteSupport
colinmarc
force-pushed
the
scrooge-write-support-2
branch
from
13eef4d to
e2a0abd
Compare
Contributor
Author
|
Done! |
Contributor
|
LGTM +1 |
Contributor
Author
|
Hey folks, anything else needed from me here? We'd really like to be using master =) |
dongche
referenced
this pull request
in dongche/incubator-parquet-mr
Feb 3, 2015
… info inspection... upgrade to scrooge 3.17.0, remove reflection based field info inspection, support enum and requirement type correctly This PR is essential for scrooge write support https://github.com/apache/incubator-parquet-mr/pull/58 Author: Tianshuo Deng <[email protected]> Closes apache#88 from tsdeng/scrooge_schema_converter_upgrade and squashes the following commits: 77cc12a [Tianshuo Deng] delete empty line, retrigger jenkins 80d61ad [Tianshuo Deng] format 26e1fe1 [Tianshuo Deng] fix exception handling 706497d [Tianshuo Deng] support union 1b51f0f [Tianshuo Deng] upgrade to scrooge 3.17.0, remove reflection based field info inspection, support enum and requirement type correctly
Member
|
Sounds good to me! |
Contributor
|
Hi, @colinmarc |
Contributor
Author
|
Yay! Will do. |
colinmarc
changed the title
|
🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to https://github.com/apache/incubator-parquet-mr/pull/43, but instead of making
ThriftWriteSupportabstract, it keeps it around (but deprecated) and addsAbstractThriftWriteSupport. This is a little less elegant, but it seems to appease the semver overlords.