Closed
Conversation
rdblue
force-pushed
the
PARQUET-192-fix-map-null-encoding
branch
from
b2722a3 to
667d74a
Compare
Member
There was a problem hiding this comment.
Nit: should say empty (or null) value
Member
|
This looks good. Looks like it overlaps with https://github.com/apache/incubator-parquet-mr/pull/126 |
Contributor
Author
|
This PR is based on the fix for PARQUET-191, which is #126. |
rdblue
force-pushed
the
PARQUET-192-fix-map-null-encoding
branch
2 times, most recently
from
2868cc8 to
3bf2560
Compare
rdblue
force-pushed
the
PARQUET-192-fix-map-null-encoding
branch
from
3bf2560 to
fffde82
Compare
Contributor
Author
|
I've fixed the problems and rebased on master now that PARQUET-191 (#126) is merged. Thanks for the review, Tom! |
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Mar 9, 2015
This depends on PARQUET-191 for the correct schema representation. Author: Ryan Blue <[email protected]> Closes apache#127 from rdblue/PARQUET-192-fix-map-null-encoding and squashes the following commits: fffde82 [Ryan Blue] PARQUET-192: Fix parquet-avro maps with null values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on PARQUET-191 for the correct schema representation.