PARQUET-164: Add warning when scaling row group sizes.#119
Closed
rdblue wants to merge 1 commit intoapache:masterfrom
Closed
PARQUET-164: Add warning when scaling row group sizes.#119rdblue wants to merge 1 commit intoapache:masterfrom
rdblue wants to merge 1 commit intoapache:masterfrom
Conversation
Member
There was a problem hiding this comment.
I'm not sure we want this to show up in the case where the memory manager does not do anything special (scale == 1).
It will add noise for user that have only one writer.
Contributor
Author
There was a problem hiding this comment.
Good point, especially when the warning I added when the allocation is changed now includes this information. I've changed this back to debug.
Member
|
Just one comment otherwise, this looks good to me. |
rdblue
force-pushed
the
PARQUET-164-add-memory-manager-warning
branch
from
a1b9a2d to
241144f
Compare
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Mar 9, 2015
Author: Ryan Blue <[email protected]> Closes apache#119 from rdblue/PARQUET-164-add-memory-manager-warning and squashes the following commits: 241144f [Ryan Blue] PARQUET-164: Add warning when scaling row group sizes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.