PARQUET-157: Divide by zero fix#102
Closed
jimfcarroll wants to merge 2 commits intoapache:masterfrom
jimfcarroll:divide-by-zero-fix
Closed
PARQUET-157: Divide by zero fix#102jimfcarroll wants to merge 2 commits intoapache:masterfrom jimfcarroll:divide-by-zero-fix
jimfcarroll wants to merge 2 commits intoapache:masterfrom
jimfcarroll:divide-by-zero-fix
Conversation
jimfcarroll
changed the title
Contributor
There was a problem hiding this comment.
Does this need to be logged if the total time processing and reading is 0ms? I think it would be better to do this:
if (totalTime > 0) {
long percentReading = ...;
long percentProcessing = ...;
LOG.info("time spent so far"...);
}
Author
There was a problem hiding this comment.
I'll make that change.
I have a .gitignore change in a subsequent commit. Do you want that removed?
Contributor
|
Just one comment and I'll commit this. In the future, could you also explain any changes you include that aren't related to the fix? Wrapping the info messages in a check for |
added 2 commits
January 28, 2015 17:21
…so avoid compiling log statements in some cases where it's unnecessary.
Author
|
Okay. I updated the PR so it incorporates your suggestion. It makes sense to me. If you want me to pull the .gitignore commit, let me know. |
Member
|
+1 LGTM |
Contributor
|
Thanks @jimfcarroll! |
Author
|
Thanks! I'm looking forward to 1.6.0. |
dongche
pushed a commit
to dongche/incubator-parquet-mr
that referenced
this pull request
Feb 3, 2015
There is a divide by zero error in logging code inside the InternalParquetRecordReader. I've been running with this fixed for a while but everytime I revert I hit the problem again. I can't believe anyone else hasn't had this problem. I submitted a Jira ticket a few weeks ago but didn't hear anything on the list so here's the fix. This also avoids compiling log statements in some cases where it's unnecessary inside the checkRead method of InternalParquetRecordReader. Also added a .gitignore entry to clean up a build artifact. Author: Jim Carroll <[email protected]> Closes apache#102 from jimfcarroll/divide-by-zero-fix and squashes the following commits: 423200c [Jim Carroll] Filter out parquet-scrooge build artifact from git. 22337f3 [Jim Carroll] PARQUET-157: Fix a divide by zero error when Parquet runs quickly. Also avoid compiling log statements in some cases where it's unnecessary.
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Mar 9, 2015
There is a divide by zero error in logging code inside the InternalParquetRecordReader. I've been running with this fixed for a while but everytime I revert I hit the problem again. I can't believe anyone else hasn't had this problem. I submitted a Jira ticket a few weeks ago but didn't hear anything on the list so here's the fix. This also avoids compiling log statements in some cases where it's unnecessary inside the checkRead method of InternalParquetRecordReader. Also added a .gitignore entry to clean up a build artifact. Author: Jim Carroll <[email protected]> Closes apache#102 from jimfcarroll/divide-by-zero-fix and squashes the following commits: 423200c [Jim Carroll] Filter out parquet-scrooge build artifact from git. 22337f3 [Jim Carroll] PARQUET-157: Fix a divide by zero error when Parquet runs quickly. Also avoid compiling log statements in some cases where it's unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a divide by zero error in logging code inside the InternalParquetRecordReader. I've been running with this fixed for a while but everytime I revert I hit the problem again. I can't believe anyone else hasn't had this problem. I submitted a Jira ticket a few weeks ago but didn't hear anything on the list so here's the fix.
This also avoids compiling log statements in some cases where it's unnecessary inside the checkRead method of InternalParquetRecordReader.
Also added a .gitignore entry to clean up a build artifact.