Closed
Conversation
Contributor
Author
|
@julienledem, can you review? I'm interested in getting this into 2.3.2 as well. Thanks! |
julienledem
reviewed
Oct 10, 2017
Member
julienledem
left a comment
julienledem
left a comment
There was a problem hiding this comment.
LGTM, assuming it depends on the Logical types PR
LogicalTypes.md
Outdated
| bytes `00 11 22 33 44 55 66 77 88 99 aa bb cc dd ee ff` | ||
| (This example is from [wikipedia's UUID page][wiki-uuid]). | ||
|
|
||
| The sort order used for `ENUM` values is unsigned byte-wise comparison. |
rdblue
force-pushed
the
PARQUET-1125-add-uuid-logical-type
branch
from
00a80bf to
6d618bd
Compare
Contributor
Author
|
Thanks for the review. I updated the typo you caught and will merge when tests pass, unless anyone objects. |
rdblue
force-pushed
the
PARQUET-1125-add-uuid-logical-type
branch
from
6d618bd to
dc01707
Compare
3 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UUIDs are commonly used as unique identifiers. A binary representation will reduce memory when writing or building bloom filters and will reduce cycles needed to compare values.
This commit is based on PARQUET-906 / PR #51.