PARQUET-1032: fix varint-encode() encoding algorithm link#69
Closed
kostya-sh wants to merge 1 commit intoapache:masterfrom
kostya-sh:patch-1
Closed
PARQUET-1032: fix varint-encode() encoding algorithm link#69kostya-sh wants to merge 1 commit intoapache:masterfrom kostya-sh:patch-1
kostya-sh wants to merge 1 commit intoapache:masterfrom
kostya-sh:patch-1
Conversation
Contributor
|
LGTM, thanks for fixing this. You could also correct the "http" in L233 to "https" while you're here. |
The spec says that varint-encode() is ULEB-128 encoding but links to VLQ algorithm that is slightly different from ULEB-128. While at it use HTTPS for another wikipedia link.
Contributor
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec says that varint-encode() is ULEB-128 encoding but links to VLQ algorithm that is slightly different from ULEB-128.