Repository navigation
[core] Downcast sequence and kind columns once per merge batch - #1193
Merged
JingsongLi merged 1 commit intoOct 22, 2026
Merged
Conversation
SortMergeCursor looked up and downcast _SEQUENCE_NUMBER and _VALUE_KIND on every row it emitted. Keep the typed arrays on the cursor instead.
Contributor
Author
|
@JingsongLi a small one in the same merge loop as #1162. PTAL when you have time. |
Contributor
|
+1 |
JingsongLi
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1192
Brief change log
SortMergeCursorkeeps the typed_SEQUENCE_NUMBERand_VALUE_KINDarrays, downcast once per batch, instead of looking them up for every emitted row. A NULL or missing_VALUE_KINDstill reads as INSERT.PK merge of 2M keys × 3 overlapping rounds: 445–455 → 414–427 ms (medians over 8 alternating rounds on one instance). DV merge-on-read: 446–451 → 412–427 ms.
Tests
Covered by the existing sort-merge and KV reader tests.
Ran the ci.yml steps locally (fmt, clippy, msrv, unit, rest-server, integration, datafusion, python, go).
API and Format
None.
Documentation
None.