Repository navigation
[core] Reuse the key buffer and row list across sort-merge keys - #1162
Merged
Merged
Conversation
sort_merge_stream allocated an OwnedRow and a Vec for every primary key it merged. Both are now reused across keys. Encoded rows compare by bytes, so the key check compares the copied bytes directly.
Contributor
Author
|
@JingsongLi @leaves12138 a small one for the sort-merge read path when you get a chance, numbers are in the description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1161
Brief change log
sort_merge_streamreuses one key buffer and oneVec<MergeRow>across keys instead of allocating anOwnedRowand aVecper key. The same-key check compares the encoded row bytes, which is whatRow'sOrdcompares.PK table, 2M keys written three times, full read: 463 ms → 427 ms (about 8%), with or without DV merge-on-read. Six alternating runs each, no overlap.
Tests
No behavior change; covered by the existing sort-merge and merge engine tests.
Ran the ci.yml steps locally (fmt, clippy, msrv, unit, rest-server, integration, datafusion, python, go).
API and Format
None.
Documentation
None.