Skip to content

[core] AddColumn move support before and last. #3442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JingsongLi merged 1 commit into from
Jul 9, 2024
Merged

[core] AddColumn move support before and last. #3442

JingsongLi merged 1 commit into from
Jul 9, 2024

Conversation

@joyCurry30
Copy link
Contributor

@joyCurry30 joyCurry30 commented May 30, 2024

Purpose
[core] AddColumn move support before and last.

Linked issue: close #3316

Tests
Add test case: org.apache.paimon.schema.SchemaManagerTest#testApplyMove

API and Format
Documentation

@JingsongLi
Copy link
Contributor

JingsongLi commented Jul 3, 2024 

Error:  Failures: 
Error:    SparkSchemaEvolutionITCase.testUpdateColumnPosition:293 
Expecting actual:
  "[[CREATE TABLE paimon.default.tableAfter1 (
  a INT,
  c STRING,
  d DOUBLE,
  b BIGINT)
USING paimon
TBLPROPERTIES (
  'path' = 'file:/tmp/junit3274003400986975097/default.db/tableAfter1')
]]"
to contain:
  "CREATE TABLE paimon.default.tableAfter1 (
  a INT,
  c STRING,
  b BIGINT,
  d DOUBLE)
USING paimon
" 
[INFO] 
Error:  Tests run: 85, Failures: 1, Errors: 0, Skipped: 0

@joyCurry30
Copy link
Contributor Author

joyCurry30 commented Jul 7, 2024

@JingsongLi I have fixed the test case and improve my test case, cc plz.

JingsongLi
JingsongLi approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 05bcf0c into apache:master Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JingsongLi JingsongLi JingsongLi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] addColumn move support before and last

2 participants

@joyCurry30 @JingsongLi