ORC-875: Add GitHub Action job for Windows Server 2019 #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
Member
Author
|
Hi, @williamhyun . Could you review this? |
Member
Author
|
Thank you so much, @williamhyun . |
dongjoon-hyun
added a commit
that referenced
this pull request
Dec 30, 2021
### What changes were proposed in this pull request? This PR aims to add a test coverage for Windows on GitHub Action additionally. ### Why are the changes needed? This PR aims to replace `AppVeyor` with GitHub Action eventually. **AS IS(AppVeyor)** https://github.com/apache/orc/blob/ae660f3006cae145d0db7a897fd81fe94029c0b2/appveyor.yml#L18-L41 **THIS PR(GitHub Action)** https://github.com/apache/orc/runs/4662857757?check_suite_focus=true ``` -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe - skipped -- compiler MSVC version 19.0.24245.0 ... Test project D:/a/orc/orc/build Start 1: orc-test 1/1 Test #1: orc-test ......................... Passed 61.99 sec ``` ### How was this patch tested? Pass the GitHub Action with newly add Windows job. (cherry picked from commit 2b62dc3) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
Author
|
I backported this to branch-1.7 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add a test coverage for Windows on GitHub Action additionally.
Why are the changes needed?
This PR aims to replace
AppVeyorwith GitHub Action eventually.AS IS(AppVeyor)
orc/appveyor.yml
Lines 18 to 41 in ae660f3
THIS PR(GitHub Action)
https://github.com/apache/orc/runs/4662857757?check_suite_focus=true
How was this patch tested?
Pass the GitHub Action with newly add Windows job.