ORC-815: Build and test C++ module on CLang12 #718
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Jun 12, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. (Pending CI).
Member
|
Oh, it seems that old compilers complains about this. |
Member
|
I updated your branch to see the result. If it fails still, you can revert it, @williamhyun ~ |
Member
|
Please review and merge this if CI passed, @williamhyun . 😄 |
Member
Author
|
+1 LGTM, thank you for the edits. |
Member
|
Thank you, @williamhyun . I tested and backported this to branch-1.6 on M1. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jun 22, 2021
This PR aims to build and test the C++ module on CLang12
Currently, the build fails with new warnings.
Manually built and tested.
```
$ make test-out
Test project /Users/william/orc/build
Start 1: orc-test
1/2 Test #1: orc-test ......................... Passed 3.99 sec
Start 2: tool-test
2/2 Test #2: tool-test ........................ Passed 11.96 sec
100% tests passed, 0 tests failed out of 2
```
Closes #718
Signed-off-by: William Hyun <[email protected]>
Member
|
I'll cherry-pick to branch-1.5 for Apache ORC 1.5.13. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 12, 2021
This PR aims to build and test the C++ module on CLang12
Currently, the build fails with new warnings.
Manually built and tested.
```
$ make test-out
Test project /Users/william/orc/build
Start 1: orc-test
1/2 Test #1: orc-test ......................... Passed 3.99 sec
Start 2: tool-test
2/2 Test #2: tool-test ........................ Passed 11.96 sec
100% tests passed, 0 tests failed out of 2
```
Closes #718
Signed-off-by: William Hyun <[email protected]>
(cherry picked from commit cb86120)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to build and test the C++ module on CLang12
Why are the changes needed?
Currently, the build fails with new warnings.
How was this patch tested?
Manually built and tested.