ORC-740: Add curl in debian and ubuntu Docker files #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 pending tests |
Contributor
Even though CI tests are using plain ubuntu 20 and not our Dockerfiles -- maybe something to support in the future (at least pre-release) |
Member
|
Oh, got it. Thank you, @williamhyun and @pgaref . |
dongjoon-hyun
approved these changes
Jan 24, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Yes, pending CI although this should be tested manually.
Member
|
It seems that |
Member
|
I'll merge this to master/1.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add curl in debian and ubuntu Docker files.
Why are the changes needed?
Since we use mvnw, we need curl or wget.
How was this patch tested?
Pass the CIs.