ORC-739: Use Maven Wrapper in java/CMakeLists.txt #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 24, 2021
### What changes were proposed in this pull request? This PR aims to replace `mvn` with `mvnw` in `java.CMakeLists.txt`. ### Why are the changes needed? Some old OSes like CentOS7 may have the old Maven installation. Maven Wrapper will prevent build and test failures. ### How was this patch tested? Pass the CIs and manually do the following. ``` $ cd docker $ ./run-one.sh local ORC-739 centos7 ... exec: curl --silent --show-error -L https://www.apache.org/dyn/closer.lua?action=download&filename=/maven/maven-3/3.6.3/binaries/apache-maven-3.6.3-bin.tar.gz Using `mvn` from path: /root/orc/java/build/apache-maven-3.6.3/bin/mvn ... Using `mvn` from path: /root/orc/java/build/apache-maven-3.6.3/bin/mvn [INFO] Scanning for projects... ... Test project /root/build Start 1: orc-test 1/3 Test #1: orc-test ......................... Passed 6.72 sec Start 2: java-test 2/3 Test #2: java-test ........................ Passed 103.21 sec Start 3: tool-test 3/3 Test #3: tool-test ........................ Passed 19.69 sec 100% tests passed, 0 tests failed out of 3 Total Test time (real) = 129.62 sec Built target test-out Finished centos7 at Fri Jan 22 06:33:19 PM PST 2021 ``` (cherry picked from commit f0c5f00) Signed-off-by: Dongjoon Hyun <[email protected]>
Contributor
|
Late +1 on this -- thanks @dongjoon-hyun ! Tested the local Centos7 docker build as well and is fine :) |
Member
|
Hi, I made a PR, #633 . Could you review it? |
Member
Author
|
Thank you, @pgaref and @williamhyun ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to replace
mvnwithmvnwinjava.CMakeLists.txt.Why are the changes needed?
Some old OSes like CentOS7 may have the old Maven installation. Maven Wrapper will prevent build and test failures.
How was this patch tested?
Pass the CIs and manually do the following.