ORC-2013: [C++] Bump to CMake 3.25+ to use FetchContent #2416

wgtmac · 2025-09-26T09:14:49Z

What changes were proposed in this pull request?

Rename builtin FindXXX.cmake to FindXXXAlt.cmake to not interfere with cannonical package name. These are now only used when XXX_HOME or its friends are set. This includes:
- FindGTest.cmake -> FindGTestAlt.cmake
- FindLZ4.cmake -> FindLZ4Alt.cmake
- FindProtobuf.cmake -> FindProtobufAlt.cmake
- FindSnappy.cmake -> FindSnappyAlt.cmake
- FindZLIB.cmake -> FindZLIBAlt.cmake
- FindZSTD.cmake -> FindZSTDAlt.cmake
Bump CMake minimum requirement to 3.25 to leverage FetchContent with FIND_PACKAGE_ARGS. For 3rd party dependencies now, we try to find system installed one via CONFIG mode or fallback to vendor it. This includes:
- GTest
- LZ4
- Protobuf
- Snappy
- ZSTD
- ZLIB: note that we use an unreleased version (1.4.0) to work around its misuse of build and install interface
- Sparsehash: always vendor it with workaround to its CMake misuse

Why are the changes needed?

How was this patch tested?

Pass all CIs
Test it manually

Was this patch authored or co-authored using generative AI tooling?

No

wgtmac · 2025-10-08T05:15:58Z

The two failed CIs are due to outdated CMake versions from amazonlinux23 and debian11. Should we remove them? @dongjoon-hyun

dongjoon-hyun · 2025-10-08T06:23:47Z

The two failed CIs are due to outdated CMake versions from amazonlinux23 and debian11. Should we remove them? @dongjoon-hyun

Do you mean to remove amazonlinux23 and debian11, @wgtmac ? Can we upgrade CMake on those Docker images? Then, I can help you by publishing new images.

dongjoon-hyun · 2025-10-08T06:34:15Z

For Debian 11, we can remove it because we added Debian 12 and Debian 13. However, Amazonlinux23 is the latest one. I believe we need to support it.

dongjoon-hyun · 2025-10-08T06:40:52Z

Here is the Debian 11 removal PR.

ORC-2015: Remove Debian 11 Support #2434

dongjoon-hyun · 2025-10-08T06:44:31Z

For AmazonLinux2023, I confirmed that it has CMake 3.22.2. Let me update it locally first.

$ docker run -it --rm apache/orc-dev:amazonlinux23 cmake --version
cmake version 3.22.2

dongjoon-hyun · 2025-10-08T06:49:28Z

Unfortunately, CMake version is still old even after refreshing the base image.

-FROM amazonlinux:2023
+FROM amazonlinux:2023.9.20250929.0

$ docker run -it --rm 4facd3ecc339 cmake --version
cmake version 3.22.2

CMake suite maintained and supported by Kitware (kitware.com/cmake).

kou · 2025-10-08T06:55:28Z

FYI: Apache Arrow installs newer CMake manually on Amazon Linux 2023: https://github.com/apache/arrow/blob/33d1f32136f950520dcca278b77acff430dc8dca/dev/tasks/linux-packages/apache-arrow/yum/amazon-linux-2023/Dockerfile#L64-L68

dongjoon-hyun · 2025-10-08T06:58:44Z

Good. I'll borrow that code. Thank you, @kou .

dongjoon-hyun · 2025-10-08T07:07:49Z

Here is the PR for amazonlinux:2023

ORC-2016: Upgrade CMake to 3.26.0 in amazonlinux:2023 #2435

### What changes were proposed in this pull request? This PR aims to upgrade `CMake` to 3.26.0 in `amazonlinux:2023`. ### Why are the changes needed? Currently, it has 3.22.2 which is blocking #2416 . ``` $ docker run -it --rm apache/orc-dev:amazonlinux23 cmake --version cmake version 3.22.2 ``` ### How was this patch tested? Manual build and tests. ``` $ ./reinit.sh amazonlinux23 ``` ``` $ docker run -it --rm apache/orc-dev:amazonlinux23 cmake --version cmake version 3.26.0 CMake suite maintained and supported by Kitware (kitware.com/cmake). ``` ``` $ ./run-one.sh local x amazonlinux23 Started local run for main on amazonlinux23 at Wed Oct 8 00:03:37 PDT 2025 ... Test project /root/build Start 1: orc-test 1/9 Test #1: orc-test ......................... Passed 7.77 sec Start 2: java-test 2/9 Test #2: java-test ........................ Passed 118.90 sec Start 3: java-examples-test 3/9 Test #3: java-examples-test ............... Passed 0.43 sec Start 4: java-tools-test 4/9 Test #4: java-tools-test .................. Passed 0.07 sec Start 5: java-bench-gen-test 5/9 Test #5: java-bench-gen-test .............. Passed 0.77 sec Start 6: java-bench-scan-test 6/9 Test #6: java-bench-scan-test ............. Passed 0.71 sec Start 7: java-bench-hive-test 7/9 Test #7: java-bench-hive-test ............. Passed 11.41 sec Start 8: java-bench-spark-test 8/9 Test #8: java-bench-spark-test ............ Passed 216.61 sec Start 9: tool-test 9/9 Test #9: tool-test ........................ Passed 4.37 sec 100% tests passed, 0 tests failed out of 9 Total Test time (real) = 361.08 sec Built target test-out Finished amazonlinux23 at Wed Oct 8 00:16:38 PDT 2025 ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2435 from dongjoon-hyun/ORC-2016. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>

dongjoon-hyun · 2025-10-08T07:26:05Z

New amazonlinux23 image is published and I re-triggered CI on this PR.

$ docker run -it --rm apache/orc-dev:amazonlinux23 cmake --version
cmake version 3.26.0

CMake suite maintained and supported by Kitware (kitware.com/cmake).

WillAyd · 2025-10-08T10:16:29Z

Thanks for doing this @wgtmac . I'm not sure if there's a way for me to test this out locally but if so I'm happy to try it. Otherwise looking forward to this making its way through conda

wgtmac · 2025-10-08T12:25:56Z

@WillAyd I created conda-forge/orc-feedstock#94 to test this. Let's see what's going on. (cc @h-vetinari)

wgtmac · 2025-10-08T14:08:04Z

cmake_modules/ThirdpartyToolchain.cmake


 if (DEFINED ENV{SNAPPY_HOME})
  set (SNAPPY_HOME "$ENV{SNAPPY_HOME}")
-elseif (Snappy_ROOT)


@kou I have deleted lines like these so setting XXX_ROOT will not set XXX_HOME any more and it will skip FindXXXAlt.cmake by directly jumping to the FetchContent branch.

I'm OK with removing them as an Apache Arrow developer. But controlling wheter FindXXXAlt.cmake or FetchContent by only this may not be enough... I'll comment it on the https://github.com/apache/orc/pull/2416/files#r2387031578 thread.

dongjoon-hyun

+1, LGTM. Feel free to merge, @wgtmac .

ffacs

+1, LGTM.

wgtmac · 2025-10-09T04:44:31Z

Merged this. Thanks everyone!

github-actions bot added BUILD CPP labels Sep 26, 2025

wgtmac force-pushed the fetch_content branch 15 times, most recently from 92abe65 to fd72130 Compare September 28, 2025 02:41

wgtmac changed the title ~~WIP: [C++] Bump to CMake 3.25+ to use FetchContent~~ ORC-2013: [C++] Bump to CMake 3.25+ to use FetchContent Sep 28, 2025

wgtmac force-pushed the fetch_content branch from fd72130 to 99fbd29 Compare September 28, 2025 02:54

wgtmac mentioned this pull request Sep 28, 2025

Werror in CMake Build propogates warnings from subprojects as errors apache/iceberg-cpp#246

Open

wgtmac force-pushed the fetch_content branch 8 times, most recently from a211c31 to f08a5b2 Compare September 28, 2025 09:11

github-actions bot added the INFRA label Sep 28, 2025

wgtmac marked this pull request as ready for review September 28, 2025 09:21

This was referenced Oct 8, 2025

ORC-2015: Remove Debian 11 Support #2434

Closed

ORC-2016: Upgrade CMake to 3.26.0 in amazonlinux:2023 #2435

Closed

wgtmac added 3 commits October 8, 2025 20:14

ORC-2013: [C++] Bump to CMake 3.25+ to use FetchContent

b397e46

apply block()

d8d01d2

sync conan file from upstream and make sure it works

2931d31

wgtmac force-pushed the fetch_content branch from 9999cf3 to 2931d31 Compare October 8, 2025 12:16

wgtmac added 2 commits October 8, 2025 21:19

remove unneccesary variables

4ba2df4

rename package name

5610ec8

wgtmac force-pushed the fetch_content branch from 62d0bb6 to 5610ec8 Compare October 8, 2025 13:32

wgtmac commented Oct 8, 2025

View reviewed changes

wgtmac mentioned this pull request Oct 8, 2025

test orc 2.3.0 conda-forge/orc-feedstock#94

Open

5 tasks

dongjoon-hyun approved these changes Oct 8, 2025

View reviewed changes

dongjoon-hyun added this to the 3.0.0 milestone Oct 8, 2025

ffacs approved these changes Oct 9, 2025

View reviewed changes

wgtmac closed this in 96afee0 Oct 9, 2025

ORC-2013: [C++] Bump to CMake 3.25+ to use FetchContent #2416

ORC-2013: [C++] Bump to CMake 3.25+ to use FetchContent #2416

Uh oh!

Conversation

wgtmac commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

Why are the changes needed?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

Uh oh!

wgtmac commented Oct 8, 2025

Uh oh!

dongjoon-hyun commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dongjoon-hyun commented Oct 8, 2025

Uh oh!

dongjoon-hyun commented Oct 8, 2025

Uh oh!

dongjoon-hyun commented Oct 8, 2025

Uh oh!

dongjoon-hyun commented Oct 8, 2025

Uh oh!

kou commented Oct 8, 2025

Uh oh!

dongjoon-hyun commented Oct 8, 2025

Uh oh!

dongjoon-hyun commented Oct 8, 2025

Uh oh!

dongjoon-hyun commented Oct 8, 2025

Uh oh!

WillAyd commented Oct 8, 2025

Uh oh!

wgtmac commented Oct 8, 2025

Uh oh!

wgtmac Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

kou Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun left a comment

Choose a reason for hiding this comment

Uh oh!

ffacs left a comment

Choose a reason for hiding this comment

Uh oh!

wgtmac commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

wgtmac commented Sep 26, 2025 •

edited

Loading

dongjoon-hyun commented Oct 8, 2025 •

edited

Loading