ORC-1896: Add CMAKE_POLICY_VERSION_MINIMUM=3.12 to ThirdpartyToolchain.cmake
#2398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hain.cmake` ### What changes were proposed in this pull request? This PR aims to add `CMAKE_POLICY_VERSION_MINIMUM=3.12` explicitly to `ThirdpartyToolchain.cmake` for Apache ORC 2.1.x. ### Why are the changes needed? The minimum requirement of CMake is `3.12.0` in Apache ORC 2.1.x. https://github.com/apache/orc/blob/5affc04a590780deeec7c35c7258032c3883855c/CMakeLists.txt#L18 ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#2221 from dongjoon-hyun/ORC-1896. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Sep 12, 2025
…hain.cmake` ### What changes were proposed in this pull request? This PR aims to add `CMAKE_POLICY_VERSION_MINIMUM=3.12` explicitly to `ThirdpartyToolchain.cmake` for Apache ORC 2.0.x. ### Why are the changes needed? The minimum requirement of CMake is `3.12.0` in Apache ORC 2.0.x. https://github.com/apache/orc/blob/42a9dbacc6acfcfddbb378a12bdc7c03e38590c8/CMakeLists.txt#L18 This will resolve the `branch-2.0` CI failure. - https://github.com/apache/orc/actions/runs/17686769349/job/50273163640 ``` CMake Error at /Users/runner/work/orc/orc/build/protobuf_ep-prefix/src/protobuf_ep-stamp/protobuf_ep-configure-RELWITHDEBINFO.cmake:49 (message): Command failed: 1 '/opt/homebrew/bin/cmake' '-DCMAKE_INSTALL_PREFIX=/Users/runner/work/orc/orc/build/c++/libs/thirdparty/protobuf_ep-install' '-DCMAKE_INSTALL_LIBDIR=lib' '-DBUILD_SHARED_LIBS=OFF' '-Dprotobuf_BUILD_TESTS=OFF' '-GUnix Makefiles' '-S' '/Users/runner/work/orc/orc/build/protobuf_ep-prefix/src/protobuf_ep/cmake' '-B' '/Users/runner/work/orc/orc/build/protobuf_ep-prefix/src/protobuf_ep-build' See also /Users/runner/work/orc/orc/build/protobuf_ep-prefix/src/protobuf_ep-stamp/protobuf_ep-configure-*.log make[2]: *** [protobuf_ep-prefix/src/protobuf_ep-stamp/protobuf_ep-configure] Error 1 make[1]: *** [CMakeFiles/protobuf_ep.dir/all] Error 2 make: *** [all] Error 2 ``` ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2398 from dongjoon-hyun/ORC-1896-2.0. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Member
Author
|
Merged to branch-2.0. |
Member
Author
|
For the record, 
|
Member
|
Thanks for the fix. However I don't quite understand why this fixes the CI failure... |
Member
Author
Yes, the tool change changes are suspicious to me too. The recent GitHub Action virtual image changes seem to bring some incompatible combination under the hood. This PR simplify investigated the difference between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add
CMAKE_POLICY_VERSION_MINIMUM=3.12explicitly toThirdpartyToolchain.cmakefor Apache ORC 2.0.x.Why are the changes needed?
The minimum requirement of CMake is
3.12.0in Apache ORC 2.0.x.orc/CMakeLists.txt
Line 18 in 42a9dba
This will resolve the
branch-2.0CI failure.How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.