ORC-1828: [C++] Update LZ4 to 1.10.0 #2397
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR aims to update LZ4 to 1.10.0. To use the latest version. - https://github.com/lz4/lz4/releases/tag/v1.9.4 - https://github.com/lz4/lz4/releases/tag/v1.10.0 Pass the CIs. No. Closes apache#2103 from williamhyun/ORC-1828. Authored-by: William Hyun <[email protected]> Signed-off-by: William Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 12, 2025
### What changes were proposed in this pull request? This PR aims to update LZ4 to 1.10.0. ### Why are the changes needed? To use the latest version. - https://github.com/lz4/lz4/releases/tag/v1.9.4 - https://github.com/lz4/lz4/releases/tag/v1.10.0 In addition, we need to recover the CI because currently `branch-2.0` CI is broken due to `LZ4` compilation failure like the following. - https://github.com/apache/orc/actions/runs/17686548024/job/50272495675 ``` [ 25%] Performing configure step for 'lz4_ep' CMake Error at /Users/runner/work/orc/orc/build/lz4_ep-prefix/src/lz4_ep-stamp/lz4_ep-configure-RELWITHDEBINFO.cmake:49 (message): Command failed: 1 '/opt/homebrew/bin/cmake' '-DCMAKE_INSTALL_PREFIX=/Users/runner/work/orc/orc/build/c++/libs/thirdparty/lz4_ep-install' '-DCMAKE_INSTALL_LIBDIR=lib' '-DBUILD_SHARED_LIBS=OFF' '-GUnix Makefiles' '-S' '/Users/runner/work/orc/orc/build/lz4_ep-prefix/src/lz4_ep/build/cmake' '-B' '/Users/runner/work/orc/orc/build/lz4_ep-prefix/src/lz4_ep-build' See also /Users/runner/work/orc/orc/build/lz4_ep-prefix/src/lz4_ep-stamp/lz4_ep-configure-*.log make[2]: *** [lz4_ep-prefix/src/lz4_ep-stamp/lz4_ep-configure] Error 1 make[1]: *** [CMakeFiles/lz4_ep.dir/all] Error 2 make: *** [all] Error 2 ``` ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2397 from dongjoon-hyun/ORC-1828-2.0. Authored-by: William Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Member
Author
|
Merged to branch-2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to update LZ4 to 1.10.0.
Why are the changes needed?
To use the latest version.
In addition, we need to recover the CI because currently
branch-2.0CI is broken due toLZ4compilation failure like the following.How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.