Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This PR aims to upgrade zstd to 1.5.7 in cmake_modules module.

GitHub Action MacOS 15 is updated to ZSTD 1.5.7.

Why are the changes needed?

To bring the latest bug fixes,

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

### What changes were proposed in this pull request?

This PR aims to upgrade `zstd` to 1.5.7 in `cmake_modules` module.

`GitHub Action MacOS 15` is updated to ZSTD 1.5.7.

- https://github.com/actions/runner-images/blob/macos-15-arm64/20250911.2324/images/macos/macos-15-arm64-Readme.md

### Why are the changes needed?

To bring the latest bug fixes,
- https://github.com/facebook/zstd/releases/tag/v1.5.6
- https://github.com/facebook/zstd/releases/tag/v1.5.7

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#2395 from dongjoon-hyun/ORC-1893-2.1.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun dongjoon-hyun added this to the 2.0.7 milestone Sep 12, 2025
@github-actions github-actions bot added the BUILD label Sep 12, 2025
@dongjoon-hyun
Copy link
Member Author

ZSTD passed. The current CI failure is due to LZ4.

-- zstd_ep download command succeeded.  See also /Users/runner/work/orc/orc/build/zstd_ep-prefix/src/zstd_ep-stamp/zstd_ep-download-*.log
[ 18%] No update step for 'zstd_ep'
[ 19%] No patch step for 'zstd_ep'
[ 19%] Performing configure step for 'zstd_ep'
-- zstd_ep configure command succeeded.  See also /Users/runner/work/orc/orc/build/zstd_ep-prefix/src/zstd_ep-stamp/zstd_ep-configure-*.log
[ 20%] Performing build step for 'zstd_ep'
-- zstd_ep build command succeeded.  See also /Users/runner/work/orc/orc/build/zstd_ep-prefix/src/zstd_ep-stamp/zstd_ep-build-*.log
[ 21%] Performing install step for 'zstd_ep'
-- zstd_ep install command succeeded.  See also /Users/runner/work/orc/orc/build/zstd_ep-prefix/src/zstd_ep-stamp/zstd_ep-install-*.log
[ 22%] Completed 'zstd_ep'
[ 22%] Built target zstd_ep
[ 23%] Creating directories for 'lz4_ep'
[ 24%] Performing download step (download, verify and extract) for 'lz4_ep'
-- lz4_ep download command succeeded.  See also /Users/runner/work/orc/orc/build/lz4_ep-prefix/src/lz4_ep-stamp/lz4_ep-download-*.log
[ 24%] No update step for 'lz4_ep'
[ 25%] No patch step for 'lz4_ep'
[ 25%] Performing configure step for 'lz4_ep'
CMake Error at /Users/runner/work/orc/orc/build/lz4_ep-prefix/src/lz4_ep-stamp/lz4_ep-configure-RELWITHDEBINFO.cmake:49 (message):
  Command failed: 1

   '/opt/homebrew/bin/cmake' '-DCMAKE_INSTALL_PREFIX=/Users/runner/work/orc/orc/build/c++/libs/thirdparty/lz4_ep-install' '-DCMAKE_INSTALL_LIBDIR=lib' '-DBUILD_SHARED_LIBS=OFF' '-GUnix Makefiles' '-S' '/Users/runner/work/orc/orc/build/lz4_ep-prefix/src/lz4_ep/build/cmake' '-B' '/Users/runner/work/orc/orc/build/lz4_ep-prefix/src/lz4_ep-build'

  See also

    /Users/runner/work/orc/orc/build/lz4_ep-prefix/src/lz4_ep-stamp/lz4_ep-configure-*.log


make[2]: *** [lz4_ep-prefix/src/lz4_ep-stamp/lz4_ep-configure] Error 1
make[1]: *** [CMakeFiles/lz4_ep.dir/all] Error 2
make: *** [all] Error 2

dongjoon-hyun added a commit that referenced this pull request Sep 12, 2025
### What changes were proposed in this pull request?

This PR aims to upgrade `zstd` to 1.5.7 in `cmake_modules` module.

`GitHub Action MacOS 15` is updated to ZSTD 1.5.7.

- https://github.com/actions/runner-images/blob/macos-15-arm64/20250911.2324/images/macos/macos-15-arm64-Readme.md

### Why are the changes needed?

To bring the latest bug fixes,
- https://github.com/facebook/zstd/releases/tag/v1.5.6
- https://github.com/facebook/zstd/releases/tag/v1.5.7

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #2396 from dongjoon-hyun/ORC-1893-2.0.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun
Copy link
Member Author

Merged to branch-2.0.

@dongjoon-hyun dongjoon-hyun deleted the ORC-1893-2.0 branch September 12, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant