ORC-1974: [C++] Use google::protobuf::TextFormat instead of DebugString for Protobuf v30+
#2390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tring` for `Protobuf` v30+ ### What changes were proposed in this pull request? This PR aims to use `google::protobuf::TextFormat` instead of `DebugString` for Protobuf v30+. - https://github.com/protocolbuffers/protobuf/releases/tag/v30.0 > Make DebugString print debug output, enable debug markers for debug output ### Why are the changes needed? Otherwise, our C++ `orc-metadata` tool will have a regression to expose the debug marker string, `goo.gle/debugstr`. Currently, `branch-2.1` CI is broken on `MacOS` due to this. - https://github.com/apache/orc/tree/branch-2.1 - https://github.com/apache/orc/actions/runs/17683046777/job/50261415209 ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#2387 from dongjoon-hyun/ORC-1974-2.1. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Member
Author
|
All MacOS 14 CIs passed. Since MacOS 15 CIs are failing due to a new Snappy issue, it's irrelevant. Merged to branch-2.0. |
dongjoon-hyun
added a commit
that referenced
this pull request
Sep 12, 2025
…tring` for `Protobuf` v30+ ### What changes were proposed in this pull request? This PR aims to use `google::protobuf::TextFormat` instead of `DebugString` for Protobuf v30+. - https://github.com/protocolbuffers/protobuf/releases/tag/v30.0 > Make DebugString print debug output, enable debug markers for debug output ### Why are the changes needed? Otherwise, our C++ `orc-metadata` tool will have a regression to expose the debug marker string, `goo.gle/debugstr`. Currently, `branch-2.0` CI is broken on `MacOS` due to this. - https://github.com/apache/orc/actions/runs/17683726166/job/50263664096 > +goo.gle/debugonly ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2390 from dongjoon-hyun/ORC-1974-2.0. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use
google::protobuf::TextFormatinstead ofDebugStringfor Protobuf v30+.https://github.com/protocolbuffers/protobuf/releases/tag/v30.0
Why are the changes needed?
Otherwise, our C++
orc-metadatatool will have a regression to expose the debug marker string,goo.gle/debugstr.Currently,
branch-2.0CI is broken onMacOSdue to this.How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.