ORC-1974: [C++] Use google::protobuf::TextFormat instead of DebugString for Protobuf v30+
#2358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tring` for Protobuf v30+
dongjoon-hyun
force-pushed
the
ORC-1974
branch
from
fa43efe to
466cc0d
Compare
dongjoon-hyun
changed the title
google::protobuf::TextFormat instead of DebugString for Protobuf v30+google::protobuf::TextFormat instead of DebugString for Protobuf v30+
This was referenced Aug 15, 2025
Member
Author
|
cc @wgtmac and @williamhyun |
Member
Author
|
All tests passed. Now, CIs are recovered fully. |
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 15, 2025
…tring` for `Protobuf` v30+ ### What changes were proposed in this pull request? This PR aims to use `google::protobuf::TextFormat` instead of `DebugString` for Protobuf v30+. - https://github.com/protocolbuffers/protobuf/releases/tag/v30.0 > Make DebugString print debug output, enable debug markers for debug output ### Why are the changes needed? Otherwise, our C++ `orc-metadata` tool will have a regression to expose the debug marker string, `goo.gle/debugstr`. There was a related report here. - #2239 ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2358 from dongjoon-hyun/ORC-1974. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit ddc0258) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
to dongjoon-hyun/orc
that referenced
this pull request
Sep 12, 2025
…tring` for `Protobuf` v30+ ### What changes were proposed in this pull request? This PR aims to use `google::protobuf::TextFormat` instead of `DebugString` for Protobuf v30+. - https://github.com/protocolbuffers/protobuf/releases/tag/v30.0 > Make DebugString print debug output, enable debug markers for debug output ### Why are the changes needed? Otherwise, our C++ `orc-metadata` tool will have a regression to expose the debug marker string, `goo.gle/debugstr`. There was a related report here. - apache#2239 ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#2358 from dongjoon-hyun/ORC-1974. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit ddc0258) Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 33dab29) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use
google::protobuf::TextFormatinstead ofDebugStringfor Protobuf v30+.https://github.com/protocolbuffers/protobuf/releases/tag/v30.0
Why are the changes needed?
Otherwise, our C++
orc-metadatatool will have a regression to expose the debug marker string,goo.gle/debugstr.There was a related report here.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.