ORC-1929: Fix the Javadoc of ZstdCodec.compress
#2285
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @cxzl25 |
Member
Author
|
Since this is a javadoc change, I'm going to merge. |
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 18, 2025
### What changes were proposed in this pull request? This PR aims to fix the javadoc of `ZstdCodec.compress` method. ### Why are the changes needed? The return type is `boolean` instead of `ZstdOptions`. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2285 from dongjoon-hyun/ORC-1929. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7b5b1a7) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 18, 2025
### What changes were proposed in this pull request? This PR aims to fix the javadoc of `ZstdCodec.compress` method. ### Why are the changes needed? The return type is `boolean` instead of `ZstdOptions`. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2285 from dongjoon-hyun/ORC-1929. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7b5b1a7) Signed-off-by: Dongjoon Hyun <[email protected]>
This was referenced Jun 18, 2025
Member
Author
|
Thank you, @cxzl25 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix the javadoc of
ZstdCodec.compressmethod.Why are the changes needed?
The return type is
booleaninstead ofZstdOptions.How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.