ORC-1909: Remove unused test resource log4j.properties files
#2253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 9, 2025
### What changes were proposed in this pull request? This PR aims to remove unused test resource `log4j.properties` files. ### Why are the changes needed? Aapche ORC 1.7.5 switched the deprecated `slf4j-log4j12` to `slf4j-simple` via ORC-1182. So, these test resources are unused in ORC 1.7.6+. ``` $ find . -name log4j.properties ./java/bench/core/src/resources/log4j.properties ./java/tools/src/test/resources/log4j.properties ./java/core/src/test/resources/log4j.properties ./java/shims/src/test/resources/log4j.properties ./java/mapreduce/src/test/resources/log4j.properties ``` ### How was this patch tested? Pass the CIs and manual review because this doesn't affect ORC code. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2253 from dongjoon-hyun/ORC-1909. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 4431151) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 9, 2025
### What changes were proposed in this pull request? This PR aims to remove unused test resource `log4j.properties` files. ### Why are the changes needed? Aapche ORC 1.7.5 switched the deprecated `slf4j-log4j12` to `slf4j-simple` via ORC-1182. So, these test resources are unused in ORC 1.7.6+. ``` $ find . -name log4j.properties ./java/bench/core/src/resources/log4j.properties ./java/tools/src/test/resources/log4j.properties ./java/core/src/test/resources/log4j.properties ./java/shims/src/test/resources/log4j.properties ./java/mapreduce/src/test/resources/log4j.properties ``` ### How was this patch tested? Pass the CIs and manual review because this doesn't affect ORC code. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2253 from dongjoon-hyun/ORC-1909. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 4431151) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 9, 2025
### What changes were proposed in this pull request? This PR aims to remove unused test resource `log4j.properties` files. ### Why are the changes needed? Aapche ORC 1.7.5 switched the deprecated `slf4j-log4j12` to `slf4j-simple` via ORC-1182. So, these test resources are unused in ORC 1.7.6+. ``` $ find . -name log4j.properties ./java/bench/core/src/resources/log4j.properties ./java/tools/src/test/resources/log4j.properties ./java/core/src/test/resources/log4j.properties ./java/shims/src/test/resources/log4j.properties ./java/mapreduce/src/test/resources/log4j.properties ``` ### How was this patch tested? Pass the CIs and manual review because this doesn't affect ORC code. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2253 from dongjoon-hyun/ORC-1909. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 4431151) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 9, 2025
### What changes were proposed in this pull request? This PR aims to remove unused test resource `log4j.properties` files. ### Why are the changes needed? Aapche ORC 1.7.5 switched the deprecated `slf4j-log4j12` to `slf4j-simple` via ORC-1182. So, these test resources are unused in ORC 1.7.6+. ``` $ find . -name log4j.properties ./java/bench/core/src/resources/log4j.properties ./java/tools/src/test/resources/log4j.properties ./java/core/src/test/resources/log4j.properties ./java/shims/src/test/resources/log4j.properties ./java/mapreduce/src/test/resources/log4j.properties ``` ### How was this patch tested? Pass the CIs and manual review because this doesn't affect ORC code. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2253 from dongjoon-hyun/ORC-1909. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 4431151) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
Author
|
Merged to all live release branches (main/2.1/2.0/1.9/1.8). |
This was referenced Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to remove unused test resource
log4j.propertiesfiles.Why are the changes needed?
Aapche ORC 1.7.5 switched the deprecated
slf4j-log4j12toslf4j-simplevia ORC-1182. So, these test resources are unused in ORC 1.7.6+.How was this patch tested?
Pass the CIs and manual review because this doesn't affect ORC code.
Was this patch authored or co-authored using generative AI tooling?
No.