ORC-1881: [C++] Populate dstBatch's scale and precision in DecimalConvertColumnReader #2197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kecookier
force-pushed
the
backport-2194-branch-2.0
branch
from
1da647e to
0d50dff
Compare
Author
|
@dongjoon-hyun Would you mind helping investigate the CI cpp-linter failures? This seems to be an unrelated issue, and I'm not familiar with this check. |
Member
|
I think d8e7dbf is missing in the branch-2.0 |
Author
I'll try this. |
Author
kecookier
force-pushed
the
backport-2194-branch-2.0
branch
from
ec15e85 to
0d50dff
Compare
Member
|
Could you rebase this to |
dongjoon-hyun
changed the title
…vertColumnReader Set dstBatch's decimal and precision when `DecimalConvertColumnReader::next`. Fix ORC-1881. During decimal-to-decimal conversion in `SchemaEvolution`, the target decimal's scale and precision are incorrectly initialized to zero, producing a corrupted `ColumnVectorBatch`. Unit test. No. Closes apache#2194 from kecookier/fix-decimal-2-decimal. Authored-by: zhaokuo03 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
kecookier
force-pushed
the
backport-2194-branch-2.0
branch
from
0d50dff to
012e814
Compare
Author
|
@dongjoon-hyun Thanks for the review, I've already rebased it onto branch-2.0. |
wgtmac
approved these changes
Apr 25, 2025
wgtmac
pushed a commit
that referenced
this pull request
Apr 25, 2025
…vertColumnReader ### What changes were proposed in this pull request? Set dstBatch's decimal and precision when `DecimalConvertColumnReader::next`. Fix ORC-1881. ### Why are the changes needed? During decimal-to-decimal conversion in `SchemaEvolution`, the target decimal's scale and precision are incorrectly initialized to zero, producing a corrupted `ColumnVectorBatch`. ### How was this patch tested? Unit test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2197 from kecookier/backport-2194-branch-2.0. Authored-by: zhaokuo03 <[email protected]> Signed-off-by: Gang Wu <[email protected]>
Member
|
Thanks @kecookier and @dongjoon-hyun! I've merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set dstBatch's decimal and precision when
DecimalConvertColumnReader::next.Fix ORC-1881.
Why are the changes needed?
During decimal-to-decimal conversion in
SchemaEvolution, the target decimal's scale and precision are incorrectly initialized to zero, producing a corruptedColumnVectorBatch.How was this patch tested?
Unit test.
Was this patch authored or co-authored using generative AI tooling?
No.