ORC-1881: [C++] Populate dstBatch's scale and precision in DecimalConvertColumnReader #2194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for making a PR, @kecookier .
According to the Affected Version of JIRA issues, this only affects ORC 2.x?
Author
@dongjoon-hyun Yes, the schema evolution for decimal types is introduced in ORC 2.x |
ffacs
changed the title
wgtmac
approved these changes
Apr 22, 2025
dongjoon-hyun
pushed a commit
that referenced
this pull request
Apr 22, 2025
…vertColumnReader ### What changes were proposed in this pull request? Set dstBatch's decimal and precision when `DecimalConvertColumnReader::next`. Fix ORC-1881. ### Why are the changes needed? During decimal-to-decimal conversion in `SchemaEvolution`, the target decimal's scale and precision are incorrectly initialized to zero, producing a corrupted `ColumnVectorBatch`. ### How was this patch tested? Unit test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2194 from kecookier/fix-decimal-2-decimal. Authored-by: zhaokuo03 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 44990bd) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Merged to Welcome to the Apache ORC community, @kecookier . I added you to the Apache ORC contributor group and assigned ORC-1881 to you. Since branch-2.0 is currently broken due to C++ linter error, I didn't backport this. Please make a backporting PR to branch-2.0, @kecookier . |
kecookier
pushed a commit
to kecookier/orc
that referenced
this pull request
Apr 22, 2025
…vertColumnReader ### What changes were proposed in this pull request? Set dstBatch's decimal and precision when `DecimalConvertColumnReader::next`. Fix ORC-1881. ### Why are the changes needed? During decimal-to-decimal conversion in `SchemaEvolution`, the target decimal's scale and precision are incorrectly initialized to zero, producing a corrupted `ColumnVectorBatch`. ### How was this patch tested? Unit test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#2194 from kecookier/fix-decimal-2-decimal. Authored-by: zhaokuo03 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
kecookier
pushed a commit
to kecookier/orc
that referenced
this pull request
Apr 22, 2025
…vertColumnReader Set dstBatch's decimal and precision when `DecimalConvertColumnReader::next`. Fix ORC-1881. During decimal-to-decimal conversion in `SchemaEvolution`, the target decimal's scale and precision are incorrectly initialized to zero, producing a corrupted `ColumnVectorBatch`. Unit test. No. Closes apache#2194 from kecookier/fix-decimal-2-decimal. Authored-by: zhaokuo03 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
kecookier
pushed a commit
to kecookier/orc
that referenced
this pull request
Apr 25, 2025
…vertColumnReader Set dstBatch's decimal and precision when `DecimalConvertColumnReader::next`. Fix ORC-1881. During decimal-to-decimal conversion in `SchemaEvolution`, the target decimal's scale and precision are incorrectly initialized to zero, producing a corrupted `ColumnVectorBatch`. Unit test. No. Closes apache#2194 from kecookier/fix-decimal-2-decimal. Authored-by: zhaokuo03 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set dstBatch's decimal and precision when
DecimalConvertColumnReader::next.Fix ORC-1881.
Why are the changes needed?
During decimal-to-decimal conversion in
SchemaEvolution, the target decimal's scale and precision are incorrectly initialized to zero, producing a corruptedColumnVectorBatch.How was this patch tested?
Unit test.
Was this patch authored or co-authored using generative AI tooling?
No.