ORC-1879: [C++] Fix Heap Buffer Overflow in LZO Decompression #2191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
wgtmac
changed the title
wgtmac
approved these changes
Apr 16, 2025
| 0x00, // token: extended literal length | ||
| 0xFF, // extension byte 1 | ||
|
|
||
| // Literal data: only 10 bytes far less than 273 |
Contributor
Author
There was a problem hiding this comment.
Why magic number
273?
Simply a large enough number that comes from 0x00 0xff.
dongjoon-hyun
changed the title
dongjoon-hyun
pushed a commit
that referenced
this pull request
Apr 17, 2025
### What changes were proposed in this pull request? Fix Heap Buffer Overflow Vulnerability in LZO Decompression ### Why are the changes needed? This vulnerability has several security implications ### How was this patch tested? UT passed ### Was this patch authored or co-authored using generative AI tooling? NO Closes #2191 from ffacs/main. Authored-by: ffacs <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 6b78a0d) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Apr 17, 2025
### What changes were proposed in this pull request? Fix Heap Buffer Overflow Vulnerability in LZO Decompression ### Why are the changes needed? This vulnerability has several security implications ### How was this patch tested? UT passed ### Was this patch authored or co-authored using generative AI tooling? NO Closes #2191 from ffacs/main. Authored-by: ffacs <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 6b78a0d) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Merged to main/2.1/2.0. Could you make two backport PRs for branch-1.9 and branch-1.8, please, @ffacs ? |
This was referenced Apr 17, 2025
Member
|
It seems that the patch starts to fail from |
Member
ffacs
added a commit
that referenced
this pull request
Apr 22, 2025
### What changes were proposed in this pull request? Fix Heap Buffer Overflow Vulnerability in LZO Decompression ### Why are the changes needed? This vulnerability has several security implications ### How was this patch tested? UT passed ### Was this patch authored or co-authored using generative AI tooling? NO Closes #2191 from ffacs/main. Authored-by: ffacs <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
ffacs
added a commit
to ffacs/orc
that referenced
this pull request
Apr 22, 2025
### What changes were proposed in this pull request? Fix Heap Buffer Overflow Vulnerability in LZO Decompression ### Why are the changes needed? This vulnerability has several security implications ### How was this patch tested? UT passed ### Was this patch authored or co-authored using generative AI tooling? NO Closes apache#2191 from ffacs/main. Authored-by: ffacs <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Contributor
Author
ffacs
added a commit
to ffacs/orc
that referenced
this pull request
Apr 28, 2025
### What changes were proposed in this pull request? Fix Heap Buffer Overflow Vulnerability in LZO Decompression ### Why are the changes needed? This vulnerability has several security implications ### How was this patch tested? UT passed ### Was this patch authored or co-authored using generative AI tooling? NO Closes apache#2191 from ffacs/main. Authored-by: ffacs <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix Heap Buffer Overflow Vulnerability in LZO Decompression
Why are the changes needed?
This vulnerability has several security implications
How was this patch tested?
UT passed
Was this patch authored or co-authored using generative AI tooling?
NO