ORC-1871: Include iomanip at Test(DictionaryEncoding|ConvertColumnReader)
#2175
Conversation
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for making a PR, @drupol .
Interestingly, the CI fails consecutively 4 times. Do you have any clues?
|
Hello, I don't think this is related to my changes... Or is it? Edit: After scrutinizing those logs, I'm quite confident in saying that my changes are not responsible for these breakages. |
|
I agree with you, @drupol . However, unfortunately, we cannot merge your PR when the CI complains. Could you add an empty commit to this PR in order to retry? |
|
@dongjoon-hyun done, you can restart the workflow. Crossing my fingers. |
|
All good now :) |
|
Thank you, @drupol . |
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Thanks @drupol and @dongjoon-hyun!
I think the CI failures are due to unstable connections to download dependencies.
dongjoon-hyun
changed the title
<iomanip> includesiomanip at Test(DictionaryEncoding|ConvertColumnReader)
…Reader)` ### What changes were proposed in this pull request? Add missing includes in source files ### Why are the changes needed? To package `orc` in The Linux NixOS distribution. The [PR](NixOS/nixpkgs#395541) has already be merged, it will be available to the public very soon ([PR tracker](https://nixpkgs-tracker.ocfox.me/?pr=395541)). This is [the commit](NixOS/nixpkgs@48ff182) to add `apache-orc` to NixOS in a **reproducible way**. ### How was this patch tested? Compilation is now successfully achieved with the patch. ### Was this patch authored or co-authored using generative AI tooling? Absolutely not. Closes #2175 from drupol/push-yvkkqmxxmzxl. Authored-by: Pol Dellaiera <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit af48c5d) Signed-off-by: Dongjoon Hyun <[email protected]>
…Reader)` ### What changes were proposed in this pull request? Add missing includes in source files ### Why are the changes needed? To package `orc` in The Linux NixOS distribution. The [PR](NixOS/nixpkgs#395541) has already be merged, it will be available to the public very soon ([PR tracker](https://nixpkgs-tracker.ocfox.me/?pr=395541)). This is [the commit](NixOS/nixpkgs@48ff182) to add `apache-orc` to NixOS in a **reproducible way**. ### How was this patch tested? Compilation is now successfully achieved with the patch. ### Was this patch authored or co-authored using generative AI tooling? Absolutely not. Closes #2175 from drupol/push-yvkkqmxxmzxl. Authored-by: Pol Dellaiera <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit af48c5d) Signed-off-by: Dongjoon Hyun <[email protected]>
No I don't. But it's OK, go ahead I don't think I need it. Thank you! |
3 participants
What changes were proposed in this pull request?
Add missing includes in source files
Why are the changes needed?
To package
orcin The Linux NixOS distribution. The PR has already be merged, it will be available to the public very soon (PR tracker). This is the commit to addapache-orcto NixOS in a reproducible way.How was this patch tested?
Compilation is now successfully achieved with the patch.
Was this patch authored or co-authored using generative AI tooling?
Absolutely not.