ORC-1835: [C++] Fix cpp-linter-action to build first #2113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Which branches do we need to backport, @wgtmac ? |
Member
|
For now, I set the milestone, v2.2.0, because |
Member
wgtmac
added a commit
to wgtmac/orc
that referenced
this pull request
Jan 21, 2025
Insert a build step before cpp-linter-action to do its job. We need to build C++ code to export command json file. Pass CI. No. Closes apache#2113 from wgtmac/fix_cpp_linter. Authored-by: Gang Wu <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
wgtmac
added a commit
that referenced
this pull request
Jan 21, 2025
### What changes were proposed in this pull request? Insert a build step before cpp-linter-action to do its job. This is the backport of #2113 ### Why are the changes needed? We need to build C++ code to export command json file. ### How was this patch tested? Pass CI. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2120 from wgtmac/backport_linter. Authored-by: Gang Wu <[email protected]> Signed-off-by: Gang Wu <[email protected]>
kecookier
pushed a commit
to kecookier/orc
that referenced
this pull request
Apr 23, 2025
### What changes were proposed in this pull request? Insert a build step before cpp-linter-action to do its job. ### Why are the changes needed? We need to build C++ code to export command json file. ### How was this patch tested? Pass CI. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#2113 from wgtmac/fix_cpp_linter. Authored-by: Gang Wu <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
kecookier
pushed a commit
to kecookier/orc
that referenced
this pull request
Apr 23, 2025
### What changes were proposed in this pull request? Insert a build step before cpp-linter-action to do its job. ### Why are the changes needed? We need to build C++ code to export command json file. ### How was this patch tested? Pass CI. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#2113 from wgtmac/fix_cpp_linter. Authored-by: Gang Wu <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Insert a build step before cpp-linter-action to do its job.
Why are the changes needed?
We need to build C++ code to export command json file.
How was this patch tested?
Pass CI.
Was this patch authored or co-authored using generative AI tooling?
No.