Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Dec 24, 2023

What changes were proposed in this pull request?

This PR aims to simplify fedora37 docker image for Apache ORC 2.0.

  • Explicitly install Java 17
  • Remove unused Java8 and Java 11 installation
  • Remove unused Maven installation.

Why are the changes needed?

The docker image is outdated.

  • Java 8 and 11-related branches are not used at all.
  • The installed Java 17 was due to the transitive dependency of maven installation.
  • The installed Maven is not used because we use mvnw.

How was this patch tested?

Manual tests.

$ ./run-one.sh local main fedora37
...
Test project /root/build
    Start 1: orc-test
1/8 Test #1: orc-test .........................   Passed    5.54 sec
    Start 2: java-test
2/8 Test #2: java-test ........................   Passed  118.00 sec
    Start 3: java-tools-test
3/8 Test #3: java-tools-test ..................   Passed    0.09 sec
    Start 4: java-bench-gen-test
4/8 Test #4: java-bench-gen-test ..............   Passed    0.83 sec
    Start 5: java-bench-scan-test
5/8 Test #5: java-bench-scan-test .............   Passed    0.74 sec
    Start 6: java-bench-hive-test
6/8 Test #6: java-bench-hive-test .............   Passed   11.28 sec
    Start 7: java-bench-spark-test
7/8 Test #7: java-bench-spark-test ............   Passed    3.49 sec
    Start 8: tool-test
8/8 Test #8: tool-test ........................   Passed    7.92 sec

100% tests passed, 0 tests failed out of 8

Total Test time (real) = 147.89 sec
Built target test-out
Finished fedora37 at Sat Dec 23 19:32:19 PST 2023

@github-actions github-actions bot added the INFRA label Dec 24, 2023
@dongjoon-hyun dongjoon-hyun added this to the 2.0.0 milestone Dec 24, 2023
cxzl25 pushed a commit to cxzl25/orc that referenced this pull request Jan 11, 2024
### What changes were proposed in this pull request?

This PR aims to simplify `fedora37` docker image for Apache ORC 2.0.
- Explicitly install Java 17
- Remove unused Java8 and Java 11 installation
- Remove unused Maven installation.

### Why are the changes needed?

The docker image is outdated.
- Java 8 and 11-related branches are not used at all.
- The installed Java 17 was due to the transitive dependency of `maven` installation.
- The installed `Maven` is not used because we use `mvnw`.

### How was this patch tested?

Manual tests.
```
$ ./run-one.sh local main fedora37
...
Test project /root/build
    Start 1: orc-test
1/8 Test #1: orc-test .........................   Passed    5.54 sec
    Start 2: java-test
2/8 Test #2: java-test ........................   Passed  118.00 sec
    Start 3: java-tools-test
3/8 Test #3: java-tools-test ..................   Passed    0.09 sec
    Start 4: java-bench-gen-test
4/8 Test #4: java-bench-gen-test ..............   Passed    0.83 sec
    Start 5: java-bench-scan-test
5/8 Test #5: java-bench-scan-test .............   Passed    0.74 sec
    Start 6: java-bench-hive-test
6/8 Test #6: java-bench-hive-test .............   Passed   11.28 sec
    Start 7: java-bench-spark-test
7/8 Test #7: java-bench-spark-test ............   Passed    3.49 sec
    Start 8: tool-test
8/8 Test #8: tool-test ........................   Passed    7.92 sec

100% tests passed, 0 tests failed out of 8

Total Test time (real) = 147.89 sec
Built target test-out
Finished fedora37 at Sat Dec 23 19:32:19 PST 2023
```

Closes apache#1694 from dongjoon-hyun/ORC-1555.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant