Skip to content

ORC-1541: Add Ubuntu 24.04 LTS Docker Test #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dongjoon-hyun wants to merge 2 commits into from
Closed

ORC-1541: Add Ubuntu 24.04 LTS Docker Test #1679

dongjoon-hyun wants to merge 2 commits into from

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Dec 4, 2023 •
edited
Loading

What changes were proposed in this pull request?

This PR aims to add Ubuntu 24.04 LTS Docker Test.

Why are the changes needed?

Although the official Ubuntu 24.04 LTS will arrive on April 2024, we can start to track it from the official docker dev image.

  • GNU C/CXX compiler: 13.2.0

How was this patch tested?

Manual review.

$ ./reinit.sh ubuntu24
$ ./run-one.sh local ORC-1541 ubuntu24
...
Test project /root/build
    Start 1: orc-test
1/8 Test #1: orc-test .........................   Passed    4.53 sec
    Start 2: java-test
2/8 Test #2: java-test ........................   Passed  104.55 sec
    Start 3: java-tools-test
3/8 Test #3: java-tools-test ..................   Passed    0.07 sec
    Start 4: java-bench-gen-test
4/8 Test #4: java-bench-gen-test ..............   Passed    0.74 sec
    Start 5: java-bench-scan-test
5/8 Test #5: java-bench-scan-test .............   Passed    0.69 sec
    Start 6: java-bench-hive-test
6/8 Test #6: java-bench-hive-test .............   Passed   11.21 sec
    Start 7: java-bench-spark-test
7/8 Test #7: java-bench-spark-test ............   Passed    3.36 sec
    Start 8: tool-test
8/8 Test #8: tool-test ........................   Passed    6.94 sec

100% tests passed, 0 tests failed out of 8

Total Test time (real) = 132.08 sec
Built target test-out
Finished ubuntu24 at Fri Dec  8 23:34:01 PST 2023

This closes #1501 .

@dongjoon-hyun dongjoon-hyun marked this pull request as draft December 4, 2023 06:34
@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Dec 4, 2023

This is currently blocked by libhdfs failure. I'm looking at this.

/root/build/libhdfspp_ep-prefix/src/libhdfspp_ep/include/hdfspp/uri.h:60:3: error: 'uint16_t' does not name a type
   60 |   uint16_t get_port() const;

@github-actions github-actions bot added the CPP label Dec 7, 2023
@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Dec 9, 2023

Currently, it's blocked by the following.

[ RUN      ] TestTimestampStatistics.testOldFile
unknown file: Failure
C++ exception with description "Time zone file /usr/share/zoneinfo/US/Pacific does not exist. Please install IANA time zone database and set TZDIR env." thrown in the test body.

@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review December 9, 2023 07:34
@dongjoon-hyun dongjoon-hyun added this to the 2.0.0 milestone Dec 9, 2023
@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Dec 9, 2023

I manually verified manually.

cxzl25 pushed a commit to cxzl25/orc that referenced this pull request Jan 11, 2024
@dongjoon-hyun @cxzl25
ORC-1541: Add Ubuntu 24.04 LTS Docker Test
d50e428 
### What changes were proposed in this pull request?

This PR aims to add `Ubuntu 24.04 LTS` Docker Test.

### Why are the changes needed?

Although the official `Ubuntu 24.04 LTS` will arrive on April 2024, we can start to track it from the official docker dev image.

- GNU C/CXX compiler: 13.2.0

### How was this patch tested?

Manual review.
```
$ ./reinit.sh ubuntu24
$ ./run-one.sh local ORC-1541 ubuntu24
...
Test project /root/build
    Start 1: orc-test
1/8 Test #1: orc-test .........................   Passed    4.53 sec
    Start 2: java-test
2/8 Test #2: java-test ........................   Passed  104.55 sec
    Start 3: java-tools-test
3/8 Test #3: java-tools-test ..................   Passed    0.07 sec
    Start 4: java-bench-gen-test
4/8 Test #4: java-bench-gen-test ..............   Passed    0.74 sec
    Start 5: java-bench-scan-test
5/8 Test #5: java-bench-scan-test .............   Passed    0.69 sec
    Start 6: java-bench-hive-test
6/8 Test #6: java-bench-hive-test .............   Passed   11.21 sec
    Start 7: java-bench-spark-test
7/8 Test #7: java-bench-spark-test ............   Passed    3.36 sec
    Start 8: tool-test
8/8 Test #8: tool-test ........................   Passed    6.94 sec

100% tests passed, 0 tests failed out of 8

Total Test time (real) = 132.08 sec
Built target test-out
Finished ubuntu24 at Fri Dec  8 23:34:01 PST 2023
```

This closes apache#1501 .

Closes apache#1679 from dongjoon-hyun/ORC-1541.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CPP DOCS INFRA

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

ORC-1541: Add Ubuntu 24.04 LTS Docker Test

1 participant

@dongjoon-hyun