ORC-1447: [C++] Fix a bug in CpuInfoUtil.cc to support ARM platform#1542
ORC-1447: [C++] Fix a bug in CpuInfoUtil.cc to support ARM platform#1542wgtmac merged 3 commits intoapache:mainfrom
Conversation
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you, @wpleonardo .
|
cc @santrancisco and @wgtmac |
You're welcome. It is my responsibility |
|
Thank you so much for the fix, @wpleonardo !! I saw you added support for ARMs processor 🙌 ! In our build workflows, we also support 64 bit PPC... can you extend the fix to that as well? Here is the lastest run (you can ignore some other fail tests but the most important part are Builder*** workflows). The build for ppc64 failed the same way ( |
OK, let me check this issue today |
|
@santrancisco I just added the 'ArchVerifyCpuRequirements' code to support the PPC64 platform, but I don't have PPC64 env. Could you help me check if this PR could build success on the PPC64 platform? Thank you very much! |
|
Works for us! thank you! |
### What changes were proposed in this pull request? To fix a bug reported in #1534 The bug is that some CpuInfoUtil.cc functions don't support the ARM platform. In this PR, try to fix this bug. ### Why are the changes needed? Currently, ORC can't build success on the ARM platform without this PR. ### How was this patch tested? We can build ORC on the ARM platform directly to check if it can succeed. If user enabled -DBUILD_ENABLE_AVX512=ON in the cmake process, it will get the below warning message, and BUILD_ENABLE_AVX512 will be changed back to OFF. CMake Warning at CMakeLists.txt:183 (message): Only X86 platform support AVX512 This closes #1542 (cherry picked from commit ee5e072) Signed-off-by: Dongjoon Hyun <[email protected]>
|
I backported this to |
…is now merged into apache/orc repository
|
Thank you @dongjoon-hyun! |
### What changes were proposed in this pull request? To fix a bug reported in apache#1534 The bug is that some CpuInfoUtil.cc functions don't support the ARM platform. In this PR, try to fix this bug. ### Why are the changes needed? Currently, ORC can't build success on the ARM platform without this PR. ### How was this patch tested? We can build ORC on the ARM platform directly to check if it can succeed. If user enabled -DBUILD_ENABLE_AVX512=ON in the cmake process, it will get the below warning message, and BUILD_ENABLE_AVX512 will be changed back to OFF. CMake Warning at CMakeLists.txt:183 (message): Only X86 platform support AVX512 This closes apache#1542
4 participants
What changes were proposed in this pull request?
To fix a bug reported in #1534
The bug is that some CpuInfoUtil.cc functions don't support the ARM platform. In this PR, try to fix this bug.
Why are the changes needed?
Currently, ORC can't build success on the ARM platform without this PR.
How was this patch tested?
We can build ORC on the ARM platform directly to check if it can succeed.
If user enabled -DBUILD_ENABLE_AVX512=ON in the cmake process, it will get the below warning message, and BUILD_ENABLE_AVX512 will be changed back to OFF.
CMake Warning at CMakeLists.txt:183 (message):
Only X86 platform support AVX512