ORC-1444: Enforce JDK Bytecode version #1536
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
java/pom.xml
Outdated
| <version>${maven.version}</version> | ||
| </requireMavenVersion> | ||
| <enforceBytecodeVersion> | ||
| <maxJdkVersion>1.8</maxJdkVersion> |
Member
There was a problem hiding this comment.
Maybe, after merging #1535, shall we use java.version?
java/pom.xml
Outdated
| <artifactId>extra-enforcer-rules</artifactId> | ||
| <version>1.7.0</version> | ||
| </dependency> | ||
| </dependencies> |
Member
There was a problem hiding this comment.
CI seems to complain at this due to the ordering too~
Member
Author
|
Thank you, I addressed the comments and have rebased! |
dongjoon-hyun
approved these changes
Jun 15, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (Pending CIs). Thank you for updates.
| <ignoredScopes>test</ignoredScopes> | ||
| <ignoredScopes>provided</ignoredScopes> | ||
| <excludes> | ||
| <exclude>org.threeten:threeten-extra</exclude> |
Member
There was a problem hiding this comment.
Yes, this was reported before.
Member
|
Thank you! |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jun 15, 2023
This PR aims to enforce the JDK Bytecode version. At this moment it is enforced to 1.8, however, we will be able to move it up later. This feature helps us prevent accidental addition of a higher JDK library. Pass the CIs. Closes #1536 from williamhyun/bytecode. Authored-by: William Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 2357c17) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Merged to main/1.9. |
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? This PR aims to enforce the JDK Bytecode version. At this moment it is enforced to 1.8, however, we will be able to move it up later. ### Why are the changes needed? This feature helps us prevent accidental addition of a higher JDK library. ### How was this patch tested? Pass the CIs. Closes apache#1536 from williamhyun/bytecode. Authored-by: William Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
May 23, 2025
…n` rule ### What changes were proposed in this pull request? This PR aims to remove `threeten-extra` exclusion in `enforceBytecodeVersion` rule. ### Why are the changes needed? The previous exclusion rule was added at ORC 1.9.0 with Java 1.8. It's not required for Java 17 since ORC 2.0. - #1536 ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2234 from dongjoon-hyun/ORC-1901. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
May 23, 2025
…n` rule ### What changes were proposed in this pull request? This PR aims to remove `threeten-extra` exclusion in `enforceBytecodeVersion` rule. ### Why are the changes needed? The previous exclusion rule was added at ORC 1.9.0 with Java 1.8. It's not required for Java 17 since ORC 2.0. - #1536 ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2234 from dongjoon-hyun/ORC-1901. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 1d33d2a) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
May 23, 2025
…n` rule ### What changes were proposed in this pull request? This PR aims to remove `threeten-extra` exclusion in `enforceBytecodeVersion` rule. ### Why are the changes needed? The previous exclusion rule was added at ORC 1.9.0 with Java 1.8. It's not required for Java 17 since ORC 2.0. - #1536 ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2234 from dongjoon-hyun/ORC-1901. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 1d33d2a) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to enforce the JDK Bytecode version.
At this moment it is enforced to 1.8, however, we will be able to move it up later.
Why are the changes needed?
This feature helps us prevent accidental addition of a higher JDK library.
How was this patch tested?
Pass the CIs.