Skip to content

Conversation

@williamhyun
Copy link
Member

@williamhyun williamhyun commented Aug 17, 2022

What changes were proposed in this pull request?

This PR aims to add Febdora 37 Docker test.

Why are the changes needed?

To improve test coverage.

How was this patch tested?

Manually test on AMD64.
Note that ORC-762 still exists; protobuffer 2.5.0 only works on AMD64 and Apple silicon.

$ docker build -t apache/orc-dev:fedora37 fedora37
$ ./run-one.sh local fedora37 fedora37
...
Test project /root/build
    Start 1: orc-test
1/8 Test #1: orc-test .........................   Passed    5.35 sec
    Start 2: java-test
2/8 Test #2: java-test ........................   Passed  192.94 sec
    Start 3: java-tools-test
3/8 Test #3: java-tools-test ..................   Passed    0.14 sec
    Start 4: java-bench-gen-test
4/8 Test #4: java-bench-gen-test ..............   Passed    1.38 sec
    Start 5: java-bench-scan-test
5/8 Test #5: java-bench-scan-test .............   Passed    1.23 sec
    Start 6: java-bench-hive-test
6/8 Test #6: java-bench-hive-test .............   Passed   13.55 sec
    Start 7: java-bench-spark-test
7/8 Test #7: java-bench-spark-test ............   Passed    4.66 sec
    Start 8: tool-test
8/8 Test #8: tool-test ........................   Passed   10.70 sec

100% tests passed, 0 tests failed out of 8

Total Test time (real) = 229.97 sec
Built target test-out
Finished fedora37 at Wed Aug 17 13:10:33 PDT 2022

@dongjoon-hyun
Copy link
Member

Thank you, @williamhyun . It looks promising . Let me check this manually.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's not published yet to Apache ORC docker hub, I tested like the following on my Intel MacBook.

$ docker build -t apache/orc-dev:fedora37 fedora37
$ ./run-one.sh local fedora37 fedora37
...
Test project /root/build
    Start 1: orc-test
1/8 Test #1: orc-test .........................   Passed    5.35 sec
    Start 2: java-test
2/8 Test #2: java-test ........................   Passed  192.94 sec
    Start 3: java-tools-test
3/8 Test #3: java-tools-test ..................   Passed    0.14 sec
    Start 4: java-bench-gen-test
4/8 Test #4: java-bench-gen-test ..............   Passed    1.38 sec
    Start 5: java-bench-scan-test
5/8 Test #5: java-bench-scan-test .............   Passed    1.23 sec
    Start 6: java-bench-hive-test
6/8 Test #6: java-bench-hive-test .............   Passed   13.55 sec
    Start 7: java-bench-spark-test
7/8 Test #7: java-bench-spark-test ............   Passed    4.66 sec
    Start 8: tool-test
8/8 Test #8: tool-test ........................   Passed   10.70 sec

100% tests passed, 0 tests failed out of 8

Total Test time (real) = 229.97 sec
Built target test-out
Finished fedora37 at Wed Aug 17 13:10:33 PDT 2022

@dongjoon-hyun
Copy link
Member

I'll put the above result into the PR description.

dongjoon-hyun pushed a commit that referenced this pull request Aug 17, 2022
### What changes were proposed in this pull request?
This PR aims to add Febdora 37 Docker test.

### Why are the changes needed?
To improve test coverage.

### How was this patch tested?
Manually test on AMD64.
Note that ORC-762 still exists; protobuffer 2.5.0 only works on AMD64 and Apple silicon.

```
$ docker build -t apache/orc-dev:fedora37 fedora37
$ ./run-one.sh local fedora37 fedora37
...
Test project /root/build
    Start 1: orc-test
1/8 Test #1: orc-test .........................   Passed    5.35 sec
    Start 2: java-test
2/8 Test #2: java-test ........................   Passed  192.94 sec
    Start 3: java-tools-test
3/8 Test #3: java-tools-test ..................   Passed    0.14 sec
    Start 4: java-bench-gen-test
4/8 Test #4: java-bench-gen-test ..............   Passed    1.38 sec
    Start 5: java-bench-scan-test
5/8 Test #5: java-bench-scan-test .............   Passed    1.23 sec
    Start 6: java-bench-hive-test
6/8 Test #6: java-bench-hive-test .............   Passed   13.55 sec
    Start 7: java-bench-spark-test
7/8 Test #7: java-bench-spark-test ............   Passed    4.66 sec
    Start 8: tool-test
8/8 Test #8: tool-test ........................   Passed   10.70 sec

100% tests passed, 0 tests failed out of 8

Total Test time (real) = 229.97 sec
Built target test-out
Finished fedora37 at Wed Aug 17 13:10:33 PDT 2022
```

Closes #1224 from williamhyun/fedora37.

Authored-by: William Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 8f2b610)
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun dongjoon-hyun added this to the 1.8.0 milestone Aug 17, 2022
@dongjoon-hyun
Copy link
Member

FYI, I pushed to Apache ORC docker hub too.

$ docker push apache/orc-dev:fedora37
The push refers to repository [docker.io/apache/orc-dev]
5f70bf18a086: Layer already exists
a3a0cb950807: Pushed
74f7a235e6c3: Pushed
090b2a79338d: Mounted from library/fedora
fedora37: digest: sha256:969dab95e19742428c257d1de8214592fb72712a8b9c2b77e720410b7095b9c1 size: 1161

@dongjoon-hyun
Copy link
Member

Merged to main/1.8.

cxzl25 pushed a commit to cxzl25/orc that referenced this pull request Jan 11, 2024
### What changes were proposed in this pull request?
This PR aims to add Febdora 37 Docker test.

### Why are the changes needed?
To improve test coverage.

### How was this patch tested?
Manually test on AMD64.
Note that ORC-762 still exists; protobuffer 2.5.0 only works on AMD64 and Apple silicon.

```
$ docker build -t apache/orc-dev:fedora37 fedora37
$ ./run-one.sh local fedora37 fedora37
...
Test project /root/build
    Start 1: orc-test
1/8 Test #1: orc-test .........................   Passed    5.35 sec
    Start 2: java-test
2/8 Test #2: java-test ........................   Passed  192.94 sec
    Start 3: java-tools-test
3/8 Test #3: java-tools-test ..................   Passed    0.14 sec
    Start 4: java-bench-gen-test
4/8 Test #4: java-bench-gen-test ..............   Passed    1.38 sec
    Start 5: java-bench-scan-test
5/8 Test #5: java-bench-scan-test .............   Passed    1.23 sec
    Start 6: java-bench-hive-test
6/8 Test #6: java-bench-hive-test .............   Passed   13.55 sec
    Start 7: java-bench-spark-test
7/8 Test #7: java-bench-spark-test ............   Passed    4.66 sec
    Start 8: tool-test
8/8 Test #8: tool-test ........................   Passed   10.70 sec

100% tests passed, 0 tests failed out of 8

Total Test time (real) = 229.97 sec
Built target test-out
Finished fedora37 at Wed Aug 17 13:10:33 PDT 2022
```

Closes apache#1224 from williamhyun/fedora37.

Authored-by: William Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants