Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apache/orc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.8.9
Choose a base ref
...
head repository: apache/orc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.8.10
Choose a head ref
  • 5 commits
  • 19 files changed
  • 3 contributors

Commits on May 3, 2025

  1. Preparing branch for 1.8.10 development

    Signed-off-by: Gang Wu <[email protected]>
    wgtmac committed May 3, 2025
    Configuration menu
    Copy the full SHA
    a5142bb View commit details
    Browse the repository at this point in the history

Commits on May 21, 2025

  1. ORC-1898: When column is all null, NULL_SAFE_EQUALS pushdown doesn't …

    …get evaluated correctly
    
    ### What changes were proposed in this pull request?
    
    When all values in column `col_0` are `NULL`s within a row group, and we attempt to apply the predicate pushdown `col_0 <=> 'xxx'`, the `evaluatePredicateProto` function returns `TruthValue.NULL`. In this case, we can directly determine the result based on the literal value: if the literal is `NULL`, return `TruthValue.YES`, otherwise, return `TruthValue.NO`.
    
    ### Why are the changes needed?
    
    See [SPARK-52032](https://issues.apache.org/jira/projects/SPARK/issues/SPARK-52032).
    When we pushdown the NULL_SAFE_EQUALS predicate, all values of the column are `NULL`. The `evaluatePredicateProto` returns `TruthValue.NULL`, whose `isNeeded` returns false so that the whole row group is skipped by `SargApplier.pickRowGroups`, which actually is incorrect.
    
    ### How was this patch tested?
    
    There already exists unit test -- `TestOrcTimezonePPD.testTimestampAllNulls`
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    Co-authored using generative AI tooling.
    
    Closes #2223 from jayhan94/fix_null_safe_equals_pred_push.
    
    Authored-by: Jay Han <[email protected]>
    Signed-off-by: Dongjoon Hyun <[email protected]>
    (cherry picked from commit 467a293)
    Signed-off-by: Dongjoon Hyun <[email protected]>
    jayhan94 authored and dongjoon-hyun committed May 21, 2025
    Configuration menu
    Copy the full SHA
    9e3952c View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2025

  1. ORC-1909: Remove unused test resource log4j.properties files

    ### What changes were proposed in this pull request?
    
    This PR aims to remove unused test resource `log4j.properties` files.
    
    ### Why are the changes needed?
    
    Aapche ORC 1.7.5 switched the deprecated `slf4j-log4j12` to `slf4j-simple` via ORC-1182. So, these test resources are unused in ORC 1.7.6+.
    
    ```
    $ find . -name log4j.properties
    ./java/bench/core/src/resources/log4j.properties
    ./java/tools/src/test/resources/log4j.properties
    ./java/core/src/test/resources/log4j.properties
    ./java/shims/src/test/resources/log4j.properties
    ./java/mapreduce/src/test/resources/log4j.properties
    ```
    
    ### How was this patch tested?
    
    Pass the CIs and manual review because this doesn't affect ORC code.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    No.
    
    Closes #2253 from dongjoon-hyun/ORC-1909.
    
    Authored-by: Dongjoon Hyun <[email protected]>
    Signed-off-by: Dongjoon Hyun <[email protected]>
    (cherry picked from commit 4431151)
    Signed-off-by: Dongjoon Hyun <[email protected]>
    dongjoon-hyun committed Jun 9, 2025
    Configuration menu
    Copy the full SHA
    613ac7b View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2025

  1. ORC-1923: Remove Windows 2019 GitHub Action job

    This PR aims to remove `Windows 2019` GitHub Action job.
    
    Note that ORC-1924 is created in order to recover Windows test coverage later.
    - #2273
    
    `Windows 2019` is deprecated already and will be removed soon.
    - actions/runner-images#12045
    
    Manual review because this is a removal of CI.
    
    No.
    
    Closes #2274 from dongjoon-hyun/ORC-1923.
    
    Authored-by: Dongjoon Hyun <[email protected]>
    Signed-off-by: Dongjoon Hyun <[email protected]>
    (cherry picked from commit 7e452b9)
    Signed-off-by: Dongjoon Hyun <[email protected]>
    dongjoon-hyun committed Jun 17, 2025
    Configuration menu
    Copy the full SHA
    469b50f View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2025

  1. Preparing for release 1.8.10

    Signed-off-by: Dongjoon Hyun <[email protected]>
    dongjoon-hyun committed Jun 23, 2025
    Configuration menu
    Copy the full SHA
    bf5f743 View commit details
    Browse the repository at this point in the history
Loading