-
Notifications
You must be signed in to change notification settings - Fork 506
Comparing changes
Open a pull request
base repository: apache/orc
base: 8c2a034
head repository: apache/orc
compare: a5988e6
- 9 commits
- 24 files changed
- 6 contributors
Commits on Mar 17, 2025
-
Preparing branch for 2.0.5 development
Signed-off-by: Dongjoon Hyun <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 14dd7ab - Browse repository at this point
Copy the full SHA 14dd7abView commit details
Commits on Mar 30, 2025
-
ORC-1866: Avoid zlib decompression infinite loop
### What changes were proposed in this pull request? This PR aims to fix ZlibCodec decompression of damaged files can be fast fail. ### Why are the changes needed? This is a long-standing issue. The decompress method implemented by ZlibCodec may enter an infinite loop when encountering some corrupt files. jstack ```java "main" #1 [4611] prio=5 os_prio=31 cpu=55921.47ms elapsed=57.53s tid=0x0000000139014600 nid=4611 runnable [0x000000016d9fa000] java.lang.Thread.State: RUNNABLE at java.util.zip.Inflater.inflateBytesBytes(java.base21.0.5/Native Method) at java.util.zip.Inflater.inflate(java.base21.0.5/Inflater.java:376) - locked <0x00000004367befc0> (a java.util.zip.Inflater$InflaterZStreamRef) at org.apache.orc.impl.ZlibCodec.decompress(ZlibCodec.java:168) at org.apache.orc.impl.InStream$CompressedStream.readHeader(InStream.java:521) at org.apache.orc.impl.InStream$CompressedStream.ensureUncompressed(InStream.java:548) at org.apache.orc.impl.InStream$CompressedStream.read(InStream.java:535) at org.apache.orc.impl.TreeReaderFactory$BytesColumnVectorUtil.commonReadByteArrays(TreeReaderFactory.java:2052) at org.apache.orc.impl.TreeReaderFactory$BytesColumnVectorUtil.readOrcByteArrays(TreeReaderFactory.java:2071) at org.apache.orc.impl.TreeReaderFactory$StringDirectTreeReader.nextVector(TreeReaderFactory.java:2169) at org.apache.orc.impl.TreeReaderFactory$StringTreeReader.nextVector(TreeReaderFactory.java:2001) at org.apache.orc.impl.reader.tree.StructBatchReader.readBatchColumn(StructBatchReader.java:65) at org.apache.orc.impl.reader.tree.StructBatchReader.nextBatchForLevel(StructBatchReader.java:100) at org.apache.orc.impl.reader.tree.StructBatchReader.nextBatch(StructBatchReader.java:77) at org.apache.orc.impl.RecordReaderImpl.nextBatch(RecordReaderImpl.java:1432) at org.apache.orc.tools.PrintData.printJsonData(PrintData.java:208) at org.apache.orc.tools.PrintData.main(PrintData.java:288) at org.apache.orc.tools.Driver.main(Driver.java:120) ``` ### How was this patch tested? 1. local test 2. Add UT ### Was this patch authored or co-authored using generative AI tooling? No Closes #2127 from cxzl25/zlib_infinite_loop. Authored-by: sychen <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 8eaf92d) Signed-off-by: Dongjoon Hyun <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f71192f - Browse repository at this point
Copy the full SHA f71192fView commit details
Commits on Apr 4, 2025
-
ORC-1745: Remove
Ubuntu 20.04Support### What changes were proposed in this pull request? This PR aims to remove `Ubuntu 20.04` Support from Apache ORC 2.0.x according to `GitHub Action End-Of-Support of Ubuntu 20.04`. - actions/runner-images#11101 1. Remove from GitHub CIs 2. Remove from `docker` directory 3. Remove from Apache ORC Website. ### Why are the changes needed? | Version | RELEASED | END OF STANDARD SUPPORT | | - | - | - | | Ubuntu 20.04 LTS (Focal Fossa) | Apr 2020 | Apr 2025 | ### How was this patch tested? Pass the CIs. However, it will pass because this is a removal of test coverage. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2176 from dongjoon-hyun/ORC-1745-2.0. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f5367d6 - Browse repository at this point
Copy the full SHA f5367d6View commit details
Commits on Apr 8, 2025
-
ORC-1871: Include
iomanipat `Test(DictionaryEncoding|ConvertColumn……Reader)` ### What changes were proposed in this pull request? Add missing includes in source files ### Why are the changes needed? To package `orc` in The Linux NixOS distribution. The [PR](NixOS/nixpkgs#395541) has already be merged, it will be available to the public very soon ([PR tracker](https://nixpkgs-tracker.ocfox.me/?pr=395541)). This is [the commit](NixOS/nixpkgs@48ff182) to add `apache-orc` to NixOS in a **reproducible way**. ### How was this patch tested? Compilation is now successfully achieved with the patch. ### Was this patch authored or co-authored using generative AI tooling? Absolutely not. Closes #2175 from drupol/push-yvkkqmxxmzxl. Authored-by: Pol Dellaiera <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit af48c5d) Signed-off-by: Dongjoon Hyun <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f2ca8f6 - Browse repository at this point
Copy the full SHA f2ca8f6View commit details -
ORC-1822: [C++][CI] Use cpp-linter-action for clang-tidy and clang-fo…
…rmat ### What changes were proposed in this pull request? Use the GitHub cpp-linter-action to report clang-tidy/clang-format issues directly on the pull request. ### Why are the changes needed? It is much easier to use and more user-friendly. ### How was this patch tested? Pass CIs. I have also manually tested that it can report the issues. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2184 from dongjoon-hyun/ORC-1822-2.0. Authored-by: Gang Wu <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dc85f1f - Browse repository at this point
Copy the full SHA dc85f1fView commit details
Commits on Apr 17, 2025
-
ORC-1879: [C++] Fix Heap Buffer Overflow in LZO Decompression
### What changes were proposed in this pull request? Fix Heap Buffer Overflow Vulnerability in LZO Decompression ### Why are the changes needed? This vulnerability has several security implications ### How was this patch tested? UT passed ### Was this patch authored or co-authored using generative AI tooling? NO Closes #2191 from ffacs/main. Authored-by: ffacs <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 6b78a0d) Signed-off-by: Dongjoon Hyun <[email protected]>
1Configuration menu - View commit details
-
Copy full SHA for 807dcac - Browse repository at this point
Copy the full SHA 807dcacView commit details
Commits on Apr 23, 2025
-
ORC-1835: [C++] Fix cpp-linter-action to build first
### What changes were proposed in this pull request? Insert a build step before cpp-linter-action to do its job. ### Why are the changes needed? We need to build C++ code to export command json file. ### How was this patch tested? Pass CI. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2200 from kecookier/backport-2120-branch-2.0. Authored-by: Gang Wu <[email protected]> Signed-off-by: Gang Wu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6f04a2e - Browse repository at this point
Copy the full SHA 6f04a2eView commit details
Commits on Apr 25, 2025
-
ORC-1881: [C++] Populate dstBatch's scale and precision in DecimalCon…
…vertColumnReader ### What changes were proposed in this pull request? Set dstBatch's decimal and precision when `DecimalConvertColumnReader::next`. Fix ORC-1881. ### Why are the changes needed? During decimal-to-decimal conversion in `SchemaEvolution`, the target decimal's scale and precision are incorrectly initialized to zero, producing a corrupted `ColumnVectorBatch`. ### How was this patch tested? Unit test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2197 from kecookier/backport-2194-branch-2.0. Authored-by: zhaokuo03 <[email protected]> Signed-off-by: Gang Wu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 61d30bf - Browse repository at this point
Copy the full SHA 61d30bfView commit details
Commits on May 4, 2025
-
Signed-off-by: Dongjoon Hyun <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a5988e6 - Browse repository at this point
Copy the full SHA a5988e6View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 8c2a034...a5988e6