Skip to content

document new launch config for VS code >= 1.48 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexkli merged 11 commits into from
Dec 23, 2020
Merged

document new launch config for VS code >= 1.48 #82

alexkli merged 11 commits into from
Dec 23, 2020

Conversation

@alexkli
Copy link
Contributor

@alexkli alexkli commented Dec 23, 2020

Fixes #74.

Also

  • npm audit fixes
  • fix flaky test should reload local commonjs sources on file modification
  • minor usage output formatting fix

@alexkli alexkli requested review from dgrove-oss and rabbah December 23, 2020 08:03
@alexkli alexkli mentioned this pull request Dec 23, 2020
Closed
dgrove-oss
dgrove-oss approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexkli alexkli mentioned this pull request Dec 23, 2020
Closed
@alexkli
Copy link
Contributor Author

alexkli commented Dec 23, 2020 •
edited
Loading

Some tests have become very flaky: #84

It can resolve on a re-run, but it takes a couple of times way too many times or not at all.

@alexkli alexkli merged commit 2eb7c61 into master Dec 23, 2020
@alexkli alexkli deleted the audit branch December 23, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rabbah rabbah rabbah approved these changes

@dgrove-oss dgrove-oss dgrove-oss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

wskdebug does not work with new vs code debugger

3 participants

@alexkli @rabbah @dgrove-oss