Skip to content

Conversation

@alexkli
Copy link
Contributor

@alexkli alexkli commented Jul 17, 2020

Fixes #59.

@alexkli alexkli changed the title detect if debug port is already used and remove left over container #59 detect if debug port is already used and remove left over containers Jul 17, 2020
@alexkli alexkli requested review from dgrove-oss and rabbah July 17, 2020 06:36
}

getFullActionName() {
return `/${this.wskProps.namespace}/${this.actionName}`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this work for actions in a package? (I assume these are coming from the action context, so the answer to the q would be affirmative.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.actionName includes the package if there is one.

I never know what to call these various entities, namespace+package+action, only action, package+action... 😉

@alexkli alexkli merged commit 773ecb1 into master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

detect if debug port is already used, e.g. by left over container

2 participants