Skip to content

validate source path etc. before async installation of agent #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexkli merged 1 commit into from
Apr 15, 2020
Merged

validate source path etc. before async installation of agent #52

alexkli merged 1 commit into from
Apr 15, 2020

Conversation

@alexkli
Copy link
Contributor

@alexkli alexkli commented Apr 15, 2020

Fixes regression from #45.

  • separate OpenWhiskInvoker.prepare() phase for validation
  • better error msg if sourcePath points to folder
  • fix race condition on early error related shutdown

@alexkli
validate source path etc. before async installation of agent
d346e15 
- separate OpenWhiskInvoker.prepare() phase for validation
- better error msg if sourcePath points to folder
- fix race condition on early error related shutdown
@alexkli alexkli requested review from dgrove-oss and rabbah April 15, 2020 00:58
@alexkli alexkli added this to the 1.3 milestone Apr 15, 2020
@alexkli alexkli merged commit 9571e47 into master Apr 15, 2020
@alexkli alexkli deleted the fix-folder-error branch April 15, 2020 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgrove-oss dgrove-oss dgrove-oss approved these changes

@rabbah rabbah Awaiting requested review from rabbah

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

2 participants

@alexkli @dgrove-oss